Skip to content

Remove command-line arguments from Main methods in ILPROJ projects - #64482

Merged
trylek merged 1 commit into
dotnet:mainfrom
trylek:JIT-Methodical-IL-Main-args
Jan 29, 2022
Merged

Remove command-line arguments from Main methods in ILPROJ projects#64482
trylek merged 1 commit into
dotnet:mainfrom
trylek:JIT-Methodical-IL-Main-args

Conversation

@trylek

Copy link
Copy Markdown
Member

In my recent change I fixed C# test projects to stop using
command-line arguments. This follow-up change complements it by
applying the same transformation to IL projects. In most cases
the arguments were ignored so the transformation was trivial; in
the special case of twoEndFinallys.il the argument array is
passed to the method TwoEndFinallys so I patched it to allocate
a zero-sized string array instead (there are no tests passing
actual command-line arguments to the test app).

Thanks

Tomas

/cc @dotnet/jit-contrib

In my recent change I fixed C# test projects to stop using
command-line arguments. This follow-up change complements it by
applying the same transformation to IL projects. In most cases
the arguments were ignored so the transformation was trivial; in
the special case of twoEndFinallys.il the argument array is
passed to the method TwoEndFinallys so I patched it to allocate
a zero-sized string array instead (there are no tests passing
actual command-line arguments to the test app).
Thanks
Tomas
@trylektrylek added the area-Infrastructure-coreclr Only use for closed issues label Jan 29, 2022
@ghostghost assigned trylekJan 29, 2022
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

In my recent change I fixed C# test projects to stop using
command-line arguments. This follow-up change complements it by
applying the same transformation to IL projects. In most cases
the arguments were ignored so the transformation was trivial; in
the special case of twoEndFinallys.il the argument array is
passed to the method TwoEndFinallys so I patched it to allocate
a zero-sized string array instead (there are no tests passing
actual command-line arguments to the test app).

Thanks

Tomas

/cc @dotnet/jit-contrib

Author:trylek
Assignees:-
Labels:

area-Infrastructure-coreclr

Milestone:-

@trylek

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@trylek

Copy link
Copy Markdown
MemberAuthor

The one outerloop issue in the new RefField test is known and unrelated to my change that only touches tests under JIT/Methodical, merging in.

@trylek
trylek merged commit 77f4d7a into dotnet:mainJan 29, 2022
@trylek
trylek deleted the JIT-Methodical-IL-Main-args branch January 29, 2022 07:52
@ghostghost locked as resolved and limited conversation to collaborators Feb 28, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@trylek@BruceForstall