Skip to content

Use Reference items instead of P2Ps for inbox libs - #64508

Merged
ViktorHofer merged 1 commit into
dotnet:mainfrom
ViktorHofer:UseReferencesInsteadOfP2Ps
Jan 31, 2022
Merged

Use Reference items instead of P2Ps for inbox libs#64508
ViktorHofer merged 1 commit into
dotnet:mainfrom
ViktorHofer:UseReferencesInsteadOfP2Ps

Conversation

@ViktorHofer

@ViktorHoferViktorHofer commented Jan 30, 2022

Copy link
Copy Markdown
Member

Some libraries still had ProjectReferences to libraries which refs
were added to the targeting pack with the last release. Therefore these
references can just be normal "Reference" items instead of P2Ps.

@ViktorHoferViktorHofer self-assigned this Jan 30, 2022
@ghost

ghost commented Jan 30, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Some libraries still had ProjectReferences to libraries which refs
were added to the targeting pack with the last release. Therefore these
references can just be normal "Reference" items instead of P2Ps.

Author:ViktorHofer
Assignees:ViktorHofer
Labels:

area-Infrastructure-libraries

Milestone:-

@ViktorHofer
Use Reference items instead of P2Ps for inbox libs
6e03bdf
Some libraries still had ProjectReferences to libraries which refs
were added to the targeting pack with the last release. Therefore these
references can just be normal "Reference" items instead of P2Ps.
@ViktorHofer
ViktorHoferforce-pushed the UseReferencesInsteadOfP2Ps branch from f08df56 to 6e03bdfCompareJanuary 30, 2022 13:25
@ViktorHoferViktorHofer mentioned this pull request Jan 31, 2022
Merged
ericstj
ericstj approved these changes Jan 31, 2022
View reviewed changes

@ericstjericstj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if we can catch this with a validation target so that folks don't introduce more?

@ViktorHofer
ViktorHofer merged commit 4a19a49 into dotnet:mainJan 31, 2022
@ViktorHofer
ViktorHofer deleted the UseReferencesInsteadOfP2Ps branch January 31, 2022 20:16
@ViktorHofer

ViktorHofer commented Jan 31, 2022

Copy link
Copy Markdown
MemberAuthor

LGTM. I wonder if we can catch this with a validation target so that folks don't introduce more?

Such validation (either via a target or even without one) could be easily implemented. Ideally we would go the opposite way and use P2Ps everywhere which is why I'm a bit torn.

@ghostghost locked as resolved and limited conversation to collaborators Mar 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ericstjericstjericstj approved these changes
@safernsafernAwaiting requested review from safern

Assignees

@ViktorHoferViktorHofer

Labels

area-Infrastructure-libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ViktorHofer@ericstj