Skip to content

add missing test for scenario when destination file is larger than source file (it needs to be truncated) - #64537

Merged
adamsitnik merged 2 commits into
dotnet:mainfrom
adamsitnik:fileCopyTestGap
Jan 31, 2022
Merged

add missing test for scenario when destination file is larger than source file (it needs to be truncated)#64537
adamsitnik merged 2 commits into
dotnet:mainfrom
adamsitnik:fileCopyTestGap

Conversation

@adamsitnik

Copy link
Copy Markdown
Member

While experimenting with #61676 I've removed the file truncation in File.CopyTo for overwrite == true and all tests were passing.

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

While experimenting with #61676 I've removed the file truncation in File.CopyTo for overwrite == true and all tests were passing.

Author:adamsitnik
Assignees:-
Labels:

area-System.IO

Milestone:-

@adamsitnikadamsitnik added this to the 7.0.0 milestone Jan 31, 2022
@adamsitnikadamsitnik added the test-enhancement Improvements of test source code label Jan 31, 2022
Comment threadsrc/libraries/System.IO.FileSystem/tests/File/Copy.cs Outdated

@stephentoubstephentoub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Dan's comment, LGTM

@adamsitnik
adamsitnik merged commit d201ebb into dotnet:mainJan 31, 2022
@adamsitnik
adamsitnik deleted the fileCopyTestGap branch January 31, 2022 20:00
@ghostghost locked as resolved and limited conversation to collaborators Mar 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.IOtest-enhancementImprovements of test source code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@adamsitnik@stephentoub@danmoseley