Skip to content

Disable InspectVariableBeforeAndAfterAssignment test - #64546

Merged
sbomer merged 1 commit into
dotnet:mainfrom
sbomer:disableDebuggerAssignmentTest
Jan 31, 2022
Merged

Disable InspectVariableBeforeAndAfterAssignment test#64546
sbomer merged 1 commit into
dotnet:mainfrom
sbomer:disableDebuggerAssignmentTest

Conversation

@sbomer

@sbomersbomer commented Jan 31, 2022

Copy link
Copy Markdown
Member

This wasm debugger test has been causing frequent failures in the rolling build. See #64188 for details.

@sbomer
Disable InspectVariableBeforeAndAfterAssignment test
6057a86
This wasm debugger test has been causing frequent failures in the rolling build.
@ghostghost assigned sbomerJan 31, 2022
@ghost

ghost commented Jan 31, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

This wasm debugger test has been causing frequent failures in the rolling build. See #64188 for details.

Author:sbomer
Assignees:sbomer
Labels:

area-Debugger-mono

Milestone:-

@sbomer
sbomer merged commit 09f681f into dotnet:mainJan 31, 2022
@radical

radical commented Jan 31, 2022

Copy link
Copy Markdown
Member

Just curious - why was this needed after #64503 ?

@radical

radical commented Jan 31, 2022

Copy link
Copy Markdown
Member

Also, this breaks the tests:

 Build Browser wasm windows Release Mono_DebuggerTests / Build product
❌[Log] src\mono\wasm\debugger\DebuggerTestSuite\AssignmentTests.cs(41,10): error CS0246: The type or namespace name 'ActiveIssueAttribute' could not be found (are you missing a using directive or an assembly reference?)
❌[Log] src\mono\wasm\debugger\DebuggerTestSuite\AssignmentTests.cs(41,10): error CS0246: The type or namespace name 'ActiveIssue' could not be found (are you missing a using directive or an assembly reference?)

radical added a commit to radical/runtime that referenced this pull request Jan 31, 2022
@radical
Revert "Disable InspectVariableBeforeAndAfterAssignment test (dotnet#…
5b61460
…64546)"
This reverts commit 09f681f.
This isn't needed as the tests are being run only in `runtime-staging`
now. And this commit itself doesn't build.
@sbomer

sbomer commented Jan 31, 2022

Copy link
Copy Markdown
MemberAuthor

@radical, sorry, I didn't realize that this was part of the same test suite you moved to the staging pipeline. Thanks for reverting it.

@radical

radical commented Jan 31, 2022

Copy link
Copy Markdown
Member

No problem 👍

radical added a commit that referenced this pull request Feb 1, 2022
@radical
[wasm] Revert "Disable InspectVariableBeforeAndAfterAssignment test (#…
4466525
…64546)" (#64574)
This reverts commit 09f681f.
This isn't needed as the tests are being run only in `runtime-staging`
now. And this commit itself doesn't build.
@ghostghost locked as resolved and limited conversation to collaborators Mar 3, 2022
@sbomer
sbomer deleted the disableDebuggerAssignmentTest branch November 3, 2023 18:37
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar
@thaystgthaystgAwaiting requested review from thaystg

Assignees

@sbomersbomer

Labels

area-Debugger-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbomer@radical@AaronRobinsonMSFT