Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Add alignment to mapped field stream - #64559
Merged
Conversation
ghost
commented
Jan 31, 2022
Tagging subscribers to this area: @dotnet/area-system-reflection-metadata Issue DetailsBackport of #63305 to release/6.0 /cc @davidwrighton Customer ImpactTestingRisk
|
davidwrighton
commented
Jan 31, 2022
Member
@jaredpar Jared, would it be possible to run some Roslyn tests to ensure that Roslyn doesn't experience any unexpected failures with this change? |
ericstj
commented
Feb 1, 2022
Member
We need to add the project changes to version this and build it. To the SRM src csproj add <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<ServicingVersion>1</ServicingVersion> |
ericstj
commented
Feb 1, 2022
Member
I went ahead and did this. |
| <TargetFrameworks>$(NetCoreAppCurrent);netstandard2.0;net461</TargetFrameworks> | ||
| <Nullable>enable</Nullable> | ||
| <IsPackable>true</IsPackable> | ||
| <GeneratePackageOnBuild>true</GeneratePackageOnBuild> |
steveharter
approved these changes
Feb 1, 2022
steveharter
left a comment
Contributor
There was a problem hiding this comment.
Verified it's a direct port of 7.0
akoeplingerforce-pushed
the
backport/pr-63305-to-release/6.0
branch
from
February 7, 2022 22:44
bf30f14 to
c273161Comparesafern
commented
Feb 8, 2022
Member
Failures are known. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #63305 to release/6.0
/cc @davidwrighton
Customer Impact
Enable development of the
CreateSpan<T>support feature within the Roslyn compiler during the .NET 7 timeframe. For complex packaging reasons, the Roslyn compiler cannot take a dependency on bug fixes added to in a development release of the .NET system, so fixes required to develop vNext Roslyn need to be backported to a servicing release of .NET.Testing
The backport includes tests to validate that the MappedFieldStream is aligned as it should be.
Risk
Low risk. This will change the output of various compilers by adjusting padding, but not in a way which is concerning. The Roslyn team has confirmed that this sort of difference is acceptable.