Skip to content

Update Android to r23b image - #64567

Merged
directhex merged 10 commits into
dotnet:mainfrom
directhex:update-android-ndk-r23b
Feb 8, 2022
Merged

Update Android to r23b image#64567
directhex merged 10 commits into
dotnet:mainfrom
directhex:update-android-ndk-r23b

Conversation

@directhex

@directhexdirecthex commented Jan 31, 2022

Copy link
Copy Markdown
Contributor

Let's give this a full CI run, see if anything broke

@ghost

ghost commented Jan 31, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghostghost assigned directhexJan 31, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotFeb 1, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotFeb 1, 2022
@directhex

directhex commented Feb 1, 2022

Copy link
Copy Markdown
ContributorAuthor

Yes, everything broke, GNU as is gone

@dotnetdotnet deleted a comment from azure-pipelinesBotFeb 2, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotFeb 3, 2022
This was referenced Feb 3, 2022
Open
Closed
Closed
@ghost

ghost commented Feb 4, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Let's give this a full CI run, see if anything broke

Author:directhex
Assignees:directhex
Labels:

os-android, area-Infrastructure

Milestone:-

@dotnetdotnet deleted a comment from azure-pipelinesBotFeb 7, 2022
steveisok
steveisok approved these changes Feb 7, 2022
View reviewed changes

@steveisoksteveisok left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android build looks good

This was referenced Feb 7, 2022
Closed
Closed
Closed
Closed
This was referenced Feb 7, 2022
Closed
Closed
Closed
Closed
Closed
@directhex

directhex commented Feb 8, 2022

Copy link
Copy Markdown
ContributorAuthor

@steveisok is it? there are a whole lot of test failures - are those failures new or expected?

@steveisok

steveisok commented Feb 8, 2022

Copy link
Copy Markdown
Member

Details

All look like known issues to me. The ping one in particular was fixed in main yesterday.

@steveisok

steveisok commented Feb 8, 2022

Copy link
Copy Markdown
Member

The runtime tests one should be fixed by #64950

I'd suggest pulling in main and trying again.

@directhex

directhex commented Feb 8, 2022

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@dotnetdotnet deleted a comment from azure-pipelinesBotFeb 8, 2022
@azure-pipelines

azure-pipelinesBot commented Feb 8, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@directhex

directhex commented Feb 8, 2022

Copy link
Copy Markdown
ContributorAuthor

I think Android failures are a bad CI machine. I've pinged first responders on Teams

@directhex
directhex merged commit 97fc0a4 into dotnet:mainFeb 8, 2022
This was referenced Feb 8, 2022
Closed
Closed
akoeplinger added a commit to akoeplinger/runtime that referenced this pull request Feb 11, 2022
@akoeplinger
Add check for Android NDK 23 to AndroidAppBuilder
c1c7386
We recently bumped the Android NDK in dotnet#64567, add a check to CMakeLists-android.txt to validate it.
@akoeplingerakoeplinger mentioned this pull request Feb 11, 2022
Merged
akoeplinger added a commit that referenced this pull request Feb 11, 2022
@akoeplinger
Add check for Android NDK 23 to AndroidAppBuilder (#65197)
10aaeef
We recently bumped the Android NDK in #64567, add a check to CMakeLists-android.txt to validate it.
@ghostghost locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisoksteveisoksteveisok approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

Assignees

@directhexdirecthex

Labels

area-Infrastructureos-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@directhex@steveisok@jeffhandley