Skip to content

[release/6.0] [AOT] Use .short directive instead of .hword - #64637

Merged
safern merged 1 commit into
release/6.0from
backport/pr-64561-to-release/6.0
Feb 7, 2022
Merged

[release/6.0] [AOT] Use .short directive instead of .hword#64637
safern merged 1 commit into
release/6.0from
backport/pr-64561-to-release/6.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Feb 1, 2022•
edited by akoeplinger
Loading

Copy link
Copy Markdown
Contributor

Backport of #64561 to release/6.0

/cc @akoeplinger@grendello

Customer Impact

Xamarin.Android is trying to (partially) switch to LLVM-based toolchain
and it appears that the llvm-mc assembler doesn't accept .hword as a
valid directive for x86 targets.

Testing

Manual and CI testing.

Risk

Low. Since .hword is an alias for .short, which works fine, the change should be safe across all the architectures
supported by AOT.

@grendello
[AOT] Use .short directive instead of .hword
0cddc48
Xamarin.Android is trying to (partially) switch to LLVM-based toolchain
and it appears that the `llvm-mc` assembler doesn't accept `.hword` as a
valid directive for x86 targets. Since it's an alias for `.short`,
which works fine, the change should be safe across all the architectures
supported by AOT.
@ghost

ghost commented Feb 1, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost

ghost commented Feb 1, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #64561 to release/6.0

/cc @akoeplinger@grendello

Customer Impact

Xamarin.Android is trying to (partially) switch to LLVM-based toolchain
and it appears that the llvm-mc assembler doesn't accept .hword as a
valid directive for x86 targets.

Testing

Manual and CI testing.

Risk

Low. Since .hword is an alias for .short, which works fine, the change should be safe across all the architectures
supported by AOT.

Author:github-actions[bot]
Assignees:-
Labels:

Servicing-consider, os-android, area-Codegen-AOT-mono

Milestone:-

@marek-safarmarek-safar added this to the 6.0.x milestone Feb 1, 2022
@leecowleecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Feb 1, 2022
@leecowleecow modified the milestones: 6.0.x, 6.0.3Feb 1, 2022
@safern

safern commented Feb 7, 2022

Copy link
Copy Markdown
Member

@akoeplinger can we get a signoff here so that I can merge?

@akoeplinger

akoeplinger commented Feb 7, 2022

Copy link
Copy Markdown
Member

@safern done!

@safern
safern merged commit 39f85a4 into release/6.0Feb 7, 2022
@safern
safern deleted the backport/pr-64561-to-release/6.0 branch February 7, 2022 20:18
@eiriktsarpaliseiriktsarpalis mentioned this pull request Feb 25, 2022
Closed
@ghostghost locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@imhameedimhameedAwaiting requested review from imhameed
@lambdageeklambdageekAwaiting requested review from lambdageeklambdageek is a code owner
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRTSamMonoRT is a code owner
@vargazvargazAwaiting requested review from vargaz

Assignees

No one assigned

Labels

area-Codegen-AOT-monoos-androidServicing-approvedApproved for servicing release

Projects

None yet

Milestone

6.0.3

Development

Successfully merging this pull request may close these issues.

5 participants

@safern@akoeplinger@marek-safar@leecow@grendello