Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] [wasm][debugger] Fixing race condition - #64648
Merged
Merged
Conversation
ghost
commented
Feb 1, 2022
Tagging subscribers to this area: @thaystg Issue DetailsBackport of #64394 to release/6.0 /cc @thaystg Customer ImpactWhen trying to step could show the JS callstack and not the C# callstack as it's expected TestingManual tests on Blazor. RiskLow Risk, only getting the messages from a map using the id of the message.
|
lewing
commented
Feb 2, 2022
Member
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lewing
approved these changes
Feb 2, 2022
lewing
commented
Feb 17, 2022
Member
This was approved in tactics |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #64394 to release/6.0
Fix a race in command/response processing in the wasm debugger by bucketing the responses. Solves a race that can cause the front end to get out of sync with the target.
/cc @thaystg
Customer Impact
When trying to step could show the JS callstack and not the C# callstack as it's expected
Testing
Manual tests on Blazor.
Risk
Low Risk, only getting the messages from a map using the id of the message.