Skip to content

Fix mono native warnings from wasm targets - #64650

Merged
jkotas merged 4 commits into
dotnet:mainfrom
am11:feature/build/mono
Feb 9, 2022
Merged

Fix mono native warnings from wasm targets#64650
jkotas merged 4 commits into
dotnet:mainfrom
am11:feature/build/mono

Conversation

@am11

@am11am11 commented Feb 1, 2022•
edited
Loading

Copy link
Copy Markdown
Member

This is to fix native warnings in Build Browser wasm Linux release Runtime_Release succeeded logs https://dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1584905/logs/23 and Build Linux arm Debug AllSubsets_Monohttps://dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1586244/logs/523

@ghostghost added community-contribution Indicates that the PR has been added by a community member area-VM-meta-mono labels Feb 1, 2022
@am11
am11force-pushed the feature/build/mono branch from def4304 to 3880055CompareFebruary 2, 2022 10:20
@am11
am11 marked this pull request as ready for review February 2, 2022 10:21
@am11

am11 commented Feb 2, 2022

Copy link
Copy Markdown
MemberAuthor

cc @lambdageek, I experimented with unconditionally enabling Werror by default (in order to preserve the good, warning-free, state) but it started to fail other legs. Needs more work to get there.

am11
am11 commented Feb 2, 2022
View reviewed changes
Comment threadsrc/mono/mono/metadata/seq-points-data.c Outdated
@jkotasjkotas closed this Feb 8, 2022
@jkotasjkotas reopened this Feb 8, 2022
@jkotas
jkotas merged commit 32111e1 into dotnet:mainFeb 9, 2022
@ghostghost locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageeklambdageeklambdageek approved these changes
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@EgorBoEgorBoAwaiting requested review from EgorBo
@imhameedimhameedAwaiting requested review from imhameed
@marek-safarmarek-safarAwaiting requested review from marek-safar
@nariccnariccAwaiting requested review from naricc
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
+1 more reviewer
@vargazvargazvargaz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-VM-meta-monocommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@am11@vargaz@lambdageek@jkotas