Uh oh!
There was an error while loading. Please reload this page.
Clean up remaining tests under JIT/Methodical using Environment.Exit - #64706
Merged
Conversation
ghost
commented
Feb 2, 2022
Tagging subscribers to this area: @hoyosjs Issue DetailsI have manually rewritten the few remaining tests under JIT/Methodical to stop using Environment.Exit Thanks Tomas /cc @dotnet/jit-contrib
|
trylek
commented
Feb 2, 2022
MemberAuthor
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BruceForstall
approved these changes
Feb 3, 2022
BruceForstall
left a comment
Contributor
There was a problem hiding this comment.
test_implicit is tricky, but AFAICT the change looks ok.
Uh oh!
There was an error while loading. Please reload this page.
trylek
commented
Feb 3, 2022
MemberAuthor
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have manually rewritten the few remaining tests under JIT/Methodical to stop using Environment.Exit
to report their results (this was preventing in-process execution and subsequently their merging).
Thanks
Tomas
/cc @dotnet/jit-contrib