Uh oh!
There was an error while loading. Please reload this page.
Move explicit coverage entry points into separate public classes - #64708
Merged
Conversation
Previously I refactored these tests by moving the entrypoints from the shared body_xxx source files into the test-specific expl_* and seq_* source files but I didn't realize I'd also need to put them into new uniquely named classes as we clearly cannot distinguish 30 methods named AA.TestEntrypoint(). Thanks Tomas
ghost
commented
Feb 2, 2022
Tagging subscribers to this area: @hoyosjs Issue DetailsPreviously I refactored these tests by moving the entrypoints from Thanks Tomas /cc @dotnet/jit-contrib
|
trylek
commented
Feb 2, 2022
MemberAuthor
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BruceForstall
approved these changes
Feb 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously I refactored these tests by moving the entrypoints from
the shared body_xxx source files into the test-specific expl_*
and seq_* source files but I didn't realize I'd also need to put
them into new uniquely named classes as the merged wrapper
clearly cannot distinguish 30 different methods named
AA.TestEntrypoint().
Thanks
Tomas
/cc @dotnet/jit-contrib