Uh oh!
There was an error while loading. Please reload this page.
[wasm][debugger] Fix some racy tests - #64712
Merged
Merged
Conversation
ghost
commented
Feb 3, 2022
Tagging subscribers to this area: @thaystg Issue Detailsnull
|
This test is set up to pause on all exceptions. So, it has some code to hit `Debugger.resume` 100 times, hoping to skip all the non-user code exceptions. But this can sometimes not be enough, and you might have more exceptions which breaks rest of the test. Instead, we try to resume till we won't get paused for a period of 10secs. And after that, we can call the user code, and execute rest of the test. Fixesdotnet#62666 .
`DebuggerTests.MiscTests.DebugLazyLoadedAssemblyWithEmbeddedPdb` `DebuggerTests.BreakpointTests.BreakpointInAssemblyUsingTypeFromAnotherAssembly_BothDynamicallyLoaded` These tests load assemblies dynamically, and depend on breakpoints in those assemblies being resolved. But the tests don't wait for that to happen. So, they can some times fail when the managed method is invoked before the breakpoint being resolved. Fixesdotnet#62823Fixesdotnet#62667
radicalforce-pushed
the
fix-exception-test
branch
from
February 3, 2022 18:02
eba3073 to
58a7925Compareradical
marked this pull request as ready for review
February 3, 2022 18:06
radical
requested review from
lewing, marek-safar and thaystg
and removed request for
marek-safarFebruary 3, 2022 18:06
thaystg
approved these changes
Feb 3, 2022
lewing
approved these changes
Feb 3, 2022
lewing
left a comment
Member
There was a problem hiding this comment.
Looks good, should we add an explicit timeout option?
radical
commented
Feb 3, 2022
MemberAuthor
There is a per test timeout. Is that the one you meant? |
radical
commented
Feb 3, 2022
MemberAuthor
.. and I did test the case where the breakpoint is never hit, and the test fails with a timeout. |
radical
commented
Feb 3, 2022
MemberAuthor
Wasm (unrelated) test failures are because of #64769 . The (unrelated) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests that use late loaded assemblies
DebuggerTests.MiscTests.DebugLazyLoadedAssemblyWithEmbeddedPdbDebuggerTests.BreakpointTests.BreakpointInAssemblyUsingTypeFromAnotherAssembly_BothDynamicallyLoadedExceptionTestAllWithReloadFixes#62666
Fixes#62823
Fixes#62667