Uh oh!
There was an error while loading. Please reload this page.
Workaround permission issue on Android API30 emulators when pulling test results - #64744
Merged
Conversation
…est results See dotnet/xharness#385, we use the cache dir instead on API 30. Also add `a:exported="true"` which is required when targetting a newer minSdkVersion.
ghost
commented
Feb 3, 2022
Tagging subscribers to this area: @directhex Issue DetailsSee dotnet/xharness#385, we use the cache dir instead on API 30. Also add
|
premun
reviewed
Feb 3, 2022
| String cacheDir = context.getCacheDir().getAbsolutePath(); | ||
| String docsDir = getDocsDir(context); | ||
| File docsPath = context.getExternalFilesDir(Environment.DIRECTORY_DOCUMENTS); |
Member
There was a problem hiding this comment.
What's the value of Environment.DIRECTORY_DOCUMENTS?
Member
There was a problem hiding this comment.
I am asking because before we were setting env var DOCSDIR and I don't understand whether this is the same?
MemberAuthor
There was a problem hiding this comment.
You mean the enum value? It's the string Documents.
MemberAuthor
There was a problem hiding this comment.
Yeah it's unrelated to the env var we set.
premun
approved these changes
Feb 3, 2022
akoeplinger added a commit
to akoeplinger/runtime
that referenced
this pull request
Feb 7, 2022
In dotnet#64744 I changed the name of the env variable used to store the test results directoy but I didn't notice that the runtime tests don't use the same runner. Fixesdotnet#64920
elinor-fung pushed a commit
that referenced
this pull request
Feb 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See dotnet/xharness#385, we use the cache dir instead on API 30.
Also add
a:exported="true"which is required when targetting a newer minSdkVersion.