Skip to content

[wasm] Some cleanup of wasm jobs in runtime-extra-platforms - #64766

Merged
radical merged 3 commits into
dotnet:mainfrom
radical:wasm-yml
Feb 4, 2022
Merged

[wasm] Some cleanup of wasm jobs in runtime-extra-platforms#64766
radical merged 3 commits into
dotnet:mainfrom
radical:wasm-yml

Conversation

@radical

@radicalradical commented Feb 3, 2022

Copy link
Copy Markdown
Member
  • Remove WBT from extra-platforms, as it runs in runtime, and runtime-staging
  • Run library tests on NodeJS for windows too in runtime-extra-platforms.

@radicalradical added api-suggestion Early API idea and discussion, it is NOT ready for implementation area-Infrastructure-mono labels Feb 3, 2022
@ghostghost assigned radicalFeb 3, 2022
@ghost

ghost commented Feb 3, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Remove WBT from extra-platforms, as it runs in runtime, and runtime-staging
  • Run library tests on NodeJS for windows too in runtime-extra-platforms.
Author:radical
Assignees:-
Labels:

api-suggestion, area-Infrastructure-mono

Milestone:-

@radical

radical commented Feb 3, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Feb 3, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radicalradical added arch-wasm WebAssembly architecture and removed api-suggestion Early API idea and discussion, it is NOT ready for implementation labels Feb 3, 2022
@ghost

ghost commented Feb 3, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Remove WBT from extra-platforms, as it runs in runtime, and runtime-staging
  • Run library tests on NodeJS for windows too in runtime-extra-platforms.
Author:radical
Assignees:radical
Labels:

arch-wasm, area-Infrastructure-mono

Milestone:-

@radical

radical commented Feb 3, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Feb 3, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radicalradical mentioned this pull request Feb 3, 2022
Closed
@radicalradical added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 4, 2022
This was referenced Feb 4, 2022
Closed
Closed
@radicalradical removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 4, 2022
@radical

radical commented Feb 4, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Feb 4, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara

pavelsavara commented Feb 4, 2022

Copy link
Copy Markdown
Member

cc @maraf

@runfoapprunfoappBot mentioned this pull request Feb 4, 2022
Closed
@radical
radical requested a review from sbomerFebruary 4, 2022 16:17
@radical

radical commented Feb 4, 2022

Copy link
Copy Markdown
MemberAuthor

Failures are unrelated, and existing issues.

@radicalradical mentioned this pull request Feb 4, 2022
Merged
@radical
radical requested a review from premunFebruary 4, 2022 16:54
@radical
radical merged commit 078eb57 into dotnet:mainFeb 4, 2022
@radical
radical deleted the wasm-yml branch February 4, 2022 19:18
@ghostghost locked as resolved and limited conversation to collaborators Mar 7, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisoksteveisoksteveisok approved these changes
@sbomersbomersbomer approved these changes
@lewinglewingAwaiting requested review from lewing
@pavelsavarapavelsavaraAwaiting requested review from pavelsavara
@safernsafernAwaiting requested review from safern
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
@premunpremunAwaiting requested review from premun

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Infrastructure-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@radical@pavelsavara@steveisok@sbomer