Skip to content

Disable failing EventLogSession.GetProviderNames test - #64780

Merged
sbomer merged 3 commits into
dotnet:mainfrom
sbomer:disableProviderNameTests
Feb 24, 2022
Merged

Disable failing EventLogSession.GetProviderNames test#64780
sbomer merged 3 commits into
dotnet:mainfrom
sbomer:disableProviderNameTests

Conversation

@sbomer

@sbomersbomer commented Feb 4, 2022

Copy link
Copy Markdown
Member

See #64153

@ghost

ghost commented Feb 4, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghostghost assigned sbomerFeb 4, 2022
@runfoapprunfoappBot mentioned this pull request Feb 4, 2022
Closed
@ghost

ghost commented Feb 4, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-diagnostics-eventlog
See info in area-owners.md if you want to be subscribed.

Issue Details

See #64153

Author:sbomer
Assignees:sbomer
Labels:

area-System.Diagnostics.EventLog

Milestone:-

@carlossanlop

carlossanlop commented Feb 23, 2022

Copy link
Copy Markdown
Contributor

@tarekgh any chance you could help take a look at this one?

@tarekgh

tarekgh commented Feb 24, 2022

Copy link
Copy Markdown
Member

@sbomer I am seeing this is failing on x86 too. Why are we disabling this test on x64 only?

@sbomer
sbomerforce-pushed the disableProviderNameTests branch from 2ef8953 to dd65331CompareFebruary 24, 2022 17:08
@sbomer

sbomer commented Feb 24, 2022

Copy link
Copy Markdown
MemberAuthor

@sbomer I am seeing this is failing on x86 too. Why are we disabling this test on x64 only?

IIRC originally I saw it failing only on x64 and I wasn't sure if it was a recurring failure. Now that we are seeing it more often and on x86 I updated the PR to disable it on both architectures. Thanks!

tarekgh
tarekgh approved these changes Feb 24, 2022
View reviewed changes

@tarekghtarekgh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbomer

@sbomer
sbomer merged commit a82d92c into dotnet:mainFeb 24, 2022
@ghostghost locked as resolved and limited conversation to collaborators Mar 27, 2022
@sbomer
sbomer deleted the disableProviderNameTests branch November 3, 2023 18:37
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tarekghtarekghtarekgh approved these changes

Assignees

@sbomersbomer

Labels

area-System.Diagnostics.EventLog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sbomer@carlossanlop@tarekgh@jeffhandley