Skip to content

Split out clr.tools unit tests - #64788

Merged
MichalStrehovsky merged 1 commit into
dotnet:mainfrom
MichalStrehovsky:toolstests
Feb 4, 2022
Merged

Split out clr.tools unit tests#64788
MichalStrehovsky merged 1 commit into
dotnet:mainfrom
MichalStrehovsky:toolstests

Conversation

@MichalStrehovsky

@MichalStrehovskyMichalStrehovsky commented Feb 4, 2022

Copy link
Copy Markdown
Member

Don't even build them as part of the clr subset, only on demand.

Fixes#64557.

Cc @dotnet/crossgen-contrib

Don't even build them as part of the clr subset, only on demand.
@ghostghost added the area-Infrastructure-coreclr Only use for closed issues label Feb 4, 2022
@ghost

ghost commented Feb 4, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Don't even build them as part of the clr subset, only on demand.

Cc @dotnet/crossgen-contrib

Author:MichalStrehovsky
Assignees:MichalStrehovsky
Labels:

area-Infrastructure-coreclr

Milestone:-

@MichalStrehovsky
MichalStrehovsky merged commit 607dcce into dotnet:mainFeb 4, 2022
@MichalStrehovsky
MichalStrehovsky deleted the toolstests branch February 4, 2022 08:03
@BruceForstall

Copy link
Copy Markdown
Contributor

@MichalStrehovsky Thanks for doing this. Looks like I can build without specifying clr.nativeaotruntime now.

@ghostghost locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: "...nativeaot\Runtime\Full\AsmOffsets.cs' could not be found"

3 participants

@MichalStrehovsky@BruceForstall@jkotas