Skip to content

[mobile] Add extra HttpClientHandler linker substitution - #64818

Merged
marek-safar merged 2 commits into
dotnet:mainfrom
steveisok:fix-http-linker-sub
Feb 7, 2022
Merged

[mobile] Add extra HttpClientHandler linker substitution#64818
marek-safar merged 2 commits into
dotnet:mainfrom
steveisok:fix-http-linker-sub

Conversation

@steveisok

@steveisoksteveisok commented Feb 4, 2022

Copy link
Copy Markdown
Member

The linker substitution for HttpClientHandler.IsNativeHandlerEnabled only worked when in a project was set to false. Since the default for MAUI projects is true, this caused us to carry more assemblies than needed.

Fixes#64361

Steve Pfister
[mobile] Add extra HttpClientHandler linker substitution
7de11a4
The linker substitution for HttpClientHandler.IsNativeHandlerEnabled only worked when <UseNativeHttpHandler> in a project was set
to false. Since the default for MAUI projects is true, this caused us to carry more assemblies than needed.
Fixesdotnet#64361
@ghostghost added area-System.Net.Http linkable-framework Issues associated with delivering a linker friendly framework labels Feb 4, 2022
@ghostghost assigned steveisokFeb 4, 2022
@ghost

ghost commented Feb 4, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

The linker substitution for HttpClientHandler.IsNativeHandlerEnabled only worked when in a project was set to false. Since the default for MAUI projects is true, this caused us to carry more assemblies than needed.

Fixes #64361

Author:steveisok
Assignees:-
Labels:

area-System.Net.Http

Milestone:-

eerhardt
eerhardt reviewed Feb 4, 2022
View reviewed changes

@eerhardteerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way we can add a test for this? Maybe adding a https://github.com/dotnet/runtime/tree/main/src/libraries/System.Net.Http/tests/TrimmingTests ?

You can set feature switches in the trimming test following this pattern:

runtime/src/libraries/System.Runtime/tests/TrimmingTests/System.Runtime.TrimmingTests.proj

Lines 18 to 20 in 02ac5c3

<TestConsoleAppSourceFilesInclude="InvariantGlobalizationTrue.cs">
<EnabledFeatureSwitches>System.Globalization.Invariant;System.Globalization.PredefinedCulturesOnly</EnabledFeatureSwitches>
</TestConsoleAppSourceFiles>

cc @jonathanpeppers

Comment threadsrc/libraries/System.Net.Http/src/ILLink/ILLink.Substitutions.mobile.xml
@eerhardteerhardt added the size-reduction Issues impacting final app size primary for size sensitive workloads label Feb 4, 2022
@ghost

ghost commented Feb 4, 2022

Copy link
Copy Markdown

Tagging subscribers to 'size-reduction': @eerhardt, @SamMonoRT, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

The linker substitution for HttpClientHandler.IsNativeHandlerEnabled only worked when in a project was set to false. Since the default for MAUI projects is true, this caused us to carry more assemblies than needed.

Fixes #64361

Author:steveisok
Assignees:steveisok
Labels:

area-System.Net.Http, linkable-framework, size-reduction

Milestone:-

@steveisok@eerhardt
Update src/libraries/System.Net.Http/src/ILLink/ILLink.Substitutions.…
e21ac8b
…mobile.xml
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
@eerhardteerhardt removed the linkable-framework Issues associated with delivering a linker friendly framework label Feb 4, 2022
@ghostghost added the linkable-framework Issues associated with delivering a linker friendly framework label Feb 4, 2022
@ghost

ghost commented Feb 4, 2022

Copy link
Copy Markdown

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr
See info in area-owners.md if you want to be subscribed.

Issue Details

The linker substitution for HttpClientHandler.IsNativeHandlerEnabled only worked when in a project was set to false. Since the default for MAUI projects is true, this caused us to carry more assemblies than needed.

Fixes #64361

Author:steveisok
Assignees:steveisok
Labels:

area-System.Net.Http, linkable-framework, size-reduction

Milestone:-

eerhardt
eerhardt approved these changes Feb 4, 2022
View reviewed changes

@eerhardteerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Thanks for getting this fixed! It should really help app size in Maui.

Rethinking the trimming test - it isn't currently possible to write the test I mention above because we don't run the trimming tests on android or ios. See #39274

@steveisok

steveisok commented Feb 5, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0

@github-actions

github-actionsBot commented Feb 5, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1800182990

@github-actionsgithub-actionsBot mentioned this pull request Feb 5, 2022
Merged
@marek-safar
marek-safar merged commit 179ffff into dotnet:mainFeb 7, 2022
@ghostghost locked as resolved and limited conversation to collaborators Mar 9, 2022
@karelzkarelz added this to the 7.0.0 milestone Apr 8, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonathanpeppersjonathanpeppersjonathanpeppers left review comments
@eerhardteerhardteerhardt approved these changes
@marek-safarmarek-safarmarek-safar approved these changes
@simonrozsivalsimonrozsivalsimonrozsival approved these changes

Assignees

@steveisoksteveisok

Labels

area-System.Net.Httplinkable-frameworkIssues associated with delivering a linker friendly frameworksize-reductionIssues impacting final app size primary for size sensitive workloads

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

UseNativeHttpHandler=true is not trimming correctly on mobile apps

6 participants

@steveisok@marek-safar@simonrozsival@jonathanpeppers@eerhardt@karelz