Skip to content

Clean up several special tests under JIT/Methodical - #64837

Merged
trylek merged 2 commits into
dotnet:mainfrom
trylek:JIT-Methodical-specials
Feb 9, 2022
Merged

Clean up several special tests under JIT/Methodical#64837
trylek merged 2 commits into
dotnet:mainfrom
trylek:JIT-Methodical-specials

Conversation

@trylek

@trylektrylek commented Feb 5, 2022

Copy link
Copy Markdown
Member

Several IL tests listed their classes twice - presumably once as a
'declaration' and a second time as the 'definition'. Apart from
the fact that this causes trouble in my semi-automatic IL rewriter,
I don't see any reason for keeping this moving forward as it just
clutters the files and complicates their maintenance. I also found
one remaining test with main accepting command-line arguments
(previously overlooked due to lowercase m) and I manually made
the stringintern test classes public as the ILTransform tool now has
trouble understanding them due to the presence of preprocessor
directives.

Thanks

Tomas

/cc @dotnet/jit-contrib

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 5, 2022
@ghostghost assigned trylekFeb 5, 2022
@ghost

ghost commented Feb 5, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Several IL tests listed their classes twice - presumably once as a
'declaration' and a second time as the 'definition'. Apart from
the fact that this causes trouble in my semi-automatic IL rewriter,
I don't see any reason for keeping this moving forward as it just
clutters the files and complicates their maintenance. I also found
one remaining test with main accepting command-line arguments
(previously overlooked due to lowercase m) and I manually made
the stringintern test classes public as the ILTransform tool now has
trouble understanding them due to the presence of preprocessor
directives.

Thanks

Tomas

/cc @dotnet/jit-contrib

Author:trylek
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@trylektrylek added area-Infrastructure-coreclr Only use for closed issues and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Feb 5, 2022
@ghost

ghost commented Feb 5, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Several IL tests listed their classes twice - presumably once as a
'declaration' and a second time as the 'definition'. Apart from
the fact that this causes trouble in my semi-automatic IL rewriter,
I don't see any reason for keeping this moving forward as it just
clutters the files and complicates their maintenance. I also found
one remaining test with main accepting command-line arguments
(previously overlooked due to lowercase m) and I manually made
the stringintern test classes public as the ILTransform tool now has
trouble understanding them due to the presence of preprocessor
directives.

Thanks

Tomas

/cc @dotnet/jit-contrib

Author:trylek
Assignees:trylek
Labels:

area-Infrastructure-coreclr

Milestone:-

@trylektrylek added this to the 7.0.0 milestone Feb 5, 2022
@trylek

trylek commented Feb 7, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Feb 7, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@trylektrylek closed this Feb 8, 2022
@trylektrylek reopened this Feb 8, 2022
@trylek

trylek commented Feb 8, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Feb 8, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@trylek
Clean up a bunch of weird one-off test source code constructs
9c47faf
Several IL tests listed their classes twice - presumably once as a
'declaration' and ther second time as the 'definition'. Apart from
the fact that this causes trouble in my semi-automatic IL rewriter,
I don't see any reason for keeping this moving forward as it just
clutters the files and complicates their maintenance. I also found
one remaining test with main accepting command-line arguments
(previously overlooked due to lowercase m).
Thanks
Tomas
Make stringintern test classes public
Make ExplicitLayout owner class public
@trylek
Fix test class flags according to the (deleted) declaration
00bc78b
@trylek
trylekforce-pushed the JIT-Methodical-specials branch from 43a71ab to 00bc78bCompareFebruary 8, 2022 23:45
@trylek

trylek commented Feb 8, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Feb 8, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@trylek
trylek merged commit 1a2e3c3 into dotnet:mainFeb 9, 2022
@trylek
trylek deleted the JIT-Methodical-specials branch February 9, 2022 23:26
@ghostghost locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky
1 more reviewer
@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@trylektrylek

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@trylek@BruceForstall