Uh oh!
There was an error while loading. Please reload this page.
Fix System.Runtime reference versions and several test project names under JIT/Methodical - #64839
Conversation
ghost
commented
Feb 5, 2022
Tagging subscribers to this area: @hoyosjs Issue DetailsFor the project renames, the only goal was to establish the invariant that "System.Object is defined in an assembly that is not referenced, you must add a reference to System.Runtime" In all cases except for "delegatetail.il" these tests are "special" in the sense that they qualify the System.Object All these recent changes I'm publishing contribute to the test consolidation task Thanks Tomas /cc @dotnet/jit-contrib
|
trylek
commented
Feb 7, 2022
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BruceForstall
left a comment
There was a problem hiding this comment.
Did you try replacing all references to 'System.Runtime' with 'mscorlib' in IL tests? (Would that even be expected to work in all cases?)
trylek
commented
Feb 8, 2022
@BruceForstall - I did not, perhaps it might also resolve the issue but I tried to avoid excessively churning the codebase by making bulky refactorings - there are about 2.5K occurrences of [System.Runtime]System.Object in the test tree today. I agree there's value in further cleanup but for now I believe it's most important to land the primary consolidation. |
For the project renames, the only goal was to establish the invariant that
"_il_d" and "_il_r" denote IL tests. For the System.Runtime reference, I don't have
any great idea what exactly's going on - without the changes merged build fails with
"System.Object is defined in an assembly that is not referenced, you must add a reference to System.Runtime"
In all cases except for "delegatetail.il" these tests are "special" in the sense that they qualify the System.Object
type with the [System.Runtime] instead of [mscorlib] assembly as the remaining tests do. I have no idea what
the compiler doesn't like about the delegatetail.il test.
All these recent changes I'm publishing contribute to the test consolidation task
(there are just about 2-3 more to go). Please let me know if you think that fixing the PKT
is not the right way to fix this, feel free to suggest a different solution.
Thanks
Tomas
/cc @dotnet/jit-contrib