Skip to content

[wasm] improve memory access and marshaling range checks - #64845

Merged
kg merged 13 commits into
dotnet:mainfrom
pavelsavara:wasm_resize_and_int64
May 20, 2022
Merged

[wasm] improve memory access and marshaling range checks#64845
kg merged 13 commits into
dotnet:mainfrom
pavelsavara:wasm_resize_and_int64

Conversation

@pavelsavara

@pavelsavarapavelsavara commented Feb 5, 2022•
edited
Loading

Copy link
Copy Markdown
Member
  • capture updateGlobalBufferAndViews
  • remove setI64, getI64
  • add setI52, getI52, getU52, setU52
  • add getI64Big, setI64Big
  • change bind_static_method to use int52 with l signature.
  • inlined JS asserts
  • fixed existing binding for unsigned types
  • implemented range validations for all memory access and interop

@pavelsavarapavelsavara added this to the 7.0.0 milestone Feb 5, 2022
@ghost

ghost commented Feb 5, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • capture updateGlobalBufferAndViews
  • improve setI64, getI64
  • add getI64Big, setI64Big
  • fix StringDecoder root and hashtable access
Author:pavelsavara
Assignees:-
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone:7.0.0

@ghostghost assigned pavelsavaraFeb 5, 2022
@pavelsavara
pavelsavara requested review from kg and lewingFebruary 5, 2022 11:38
@pavelsavara

pavelsavara commented Feb 5, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Feb 5, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

kg
kg reviewed Feb 5, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/exports.ts Outdated
kg
kg reviewed Feb 5, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts Outdated
@pavelsavara

pavelsavara commented Feb 5, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Feb 5, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

kg
kg reviewed Feb 6, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts Outdated
@lewing

lewing commented Mar 25, 2022

Copy link
Copy Markdown
Member

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Mar 25, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara
pavelsavara commented Mar 28, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts Outdated
@pavelsavara
pavelsavara marked this pull request as draft March 31, 2022 17:10
@ghost

ghost commented Apr 15, 2022

Copy link
Copy Markdown

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@ghost

ghost commented Apr 30, 2022

Copy link
Copy Markdown

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

@ghostghost closed this Apr 30, 2022
@ghostghost removed the no-recent-activity label May 12, 2022
@pavelsavarapavelsavara mentioned this pull request May 12, 2022
Merged
@pavelsavara
* new memory accessors setI52, setI64Big, getI52, getI64Big
d119e50
* removed support for long form automatic marshaler. It has impact to mono_bind_static_method
@pavelsavara
pavelsavaraforce-pushed the wasm_resize_and_int64 branch from 4238f0a to d119e50CompareMay 13, 2022 21:30
@kg

kg commented May 13, 2022

Copy link
Copy Markdown
Contributor

Big fan of the I52 / I64Big split, good idea

@pavelsavara

pavelsavara commented May 13, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I implemented feedback from @kg about availability of BigInt and speed of BigInt allocation vs arithmetic.

I also had discussion with @lambdageek about 52 integral bits of Number vs Int64.
There are use-cases where 52 bits are useful, for example for Date.value.

We concluded that emscripten's silent usage of only lower 32 bit is bad.

I also realized that silent usage of lower 52bits could be similarly bad.
So I removed support for marshaling long signature form bind_static_method, which did silent 32bits till now.

This is breaking change, but failing fast should be better than silent data corruption on runtime.

@pavelsavara

pavelsavara commented May 19, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I realized that all the other setXXX are also silently trimming bits and not throwing on overflow.
It's like option C) above.
Should I introduce range check to all of them ?

Or remove the range check from Int52 ?
C1) Store it as the memory bits were double ?
C2) Mask any exponent bits and store it as is ?
F) round it to next int, convert NaN to 0, Number.POSITIVE_INFINITY to long.MaxValue ?

@pavelsavara

pavelsavara commented May 19, 2022

Copy link
Copy Markdown
MemberAuthor

This looks great, but we should make sure the C# -> JS path handles longs correctly (I think we just need to update the unbox primitive stuff to intentionally work in terms of I52 and throw an exception when unboxing if the long is too large)

I think we never had Number -> long conversion on mono_bind_static_method. I added test for it.

@pavelsavarapavelsavara changed the title [wasm] improve I64 memory access[wasm] improve memory access and marshaling range checksMay 19, 2022
@pavelsavara
- fixed marshaling of uint32, uint16 and byte to be unsigned
7982e54
- implemented range check on all set memory operations
- implemented also uint52
- differentiated bool marshaling because it shoud have different validation and message
@pavelsavara
inlined asserts
3e20335
@pavelsavara

pavelsavara commented May 19, 2022

Copy link
Copy Markdown
MemberAuthor

Should I introduce range check to all of them ?

We agreed with @kg to range-check them all.
That forced me to fix broken marshaling of unsigned types and bool.
I also implemented uint52.
And I implemented assert inlining, to make sure it doesn't allocate closure.

@pavelsavara

pavelsavara commented May 19, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented May 19, 2022

Copy link
Copy Markdown
Azure Pipelines failed to run 1 pipeline(s).

@pavelsavara

pavelsavara commented May 19, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented May 19, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara

pavelsavara commented May 19, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented May 19, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
pavelsavara requested a review from kgMay 19, 2022 19:18
kg
kg reviewed May 19, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js Outdated
@pavelsavara
pavelsavara requested a review from kgMay 20, 2022 09:02
kg
kg reviewed May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
kg
kg reviewed May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
kg
kg reviewed May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
kg
kg reviewed May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
kg
kg approved these changes May 20, 2022
View reviewed changes
@kg
kg merged commit e7886b2 into dotnet:mainMay 20, 2022
@pavelsavara

pavelsavara commented May 23, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@SamMonoRTSamMonoRT mentioned this pull request Jun 7, 2022
Closed
@ghostghost locked as resolved and limited conversation to collaborators Jun 22, 2022
@pavelsavara
pavelsavara deleted the wasm_resize_and_int64 branch July 14, 2022 20:46
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marek-safarmarek-safarAwaiting requested review from marek-safar
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@lambdageeklambdageekAwaiting requested review from lambdageek
1 more reviewer
@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelsavara@lewing@kg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[wasm] improve memory access and marshaling range checks by pavelsavara · Pull Request #64845 · dotnet/runtime · GitHub
Skip to content
[wasm] improve memory access and marshaling range checks - #64845
Merged
kg merged 13 commits into
dotnet:mainfrom 
pavelsavara:wasm_resize_and_int64
May 20, 2022
Merged
[wasm] improve memory access and marshaling range checks#64845
kg merged 13 commits into
dotnet:mainfrom 
pavelsavara:wasm_resize_and_int64
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Feb 5, 2022•

edited

Loading

Copy link


Copy Markdown

Member
  • capture updateGlobalBufferAndViews
  • remove setI64, getI64
  • add setI52, getI52, getU52, setU52
  • add getI64Big, setI64Big
  • change bind_static_method to use int52 with l signature.
  • inlined JS asserts
  • fixed existing binding for unsigned types
  • implemented range validations for all memory access and interop
@pavelsavarapavelsavara
added this to the 7.0.0 milestone
Feb 5, 2022
@ghost
ghost
commented
Feb 5, 2022

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • capture updateGlobalBufferAndViews
  • improve setI64, getI64
  • add getI64Big, setI64Big
  • fix StringDecoder root and hashtable access
Author:pavelsavara
Assignees:-
Labels:
arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone:7.0.0
@ghostghost
assigned pavelsavaraFeb 5, 2022
@pavelsavara
pavelsavara
requested review from
kg and lewingFebruary 5, 2022 11:38
@pavelsavara
pavelsavara
commented
Feb 5, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Feb 5, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Feb 5, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/exports.ts
Outdated

kg
kg
reviewed
Feb 5, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
Outdated

@pavelsavara
pavelsavara
commented
Feb 5, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Feb 5, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Feb 6, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
Outdated

@lewing
lewing
commented
Mar 25, 2022

Copy link


Copy Markdown

Member
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Mar 25, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
pavelsavara
pavelsavara
commented
Mar 28, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
Outdated

@pavelsavara
pavelsavara
marked this pull request as draft
March 31, 2022 17:10
@ghost
ghost
commented
Apr 15, 2022

Copy link


Copy Markdown

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.
@ghost
ghost
commented
Apr 30, 2022

Copy link


Copy Markdown

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.
@ghostghost
closed this
Apr 30, 2022
@ghostghost
removed
the 
no-recent-activity

label
May 12, 2022
@pavelsavarapavelsavara
mentioned this pull request
May 12, 2022
 Merged

@pavelsavara
* new memory accessors setI52, setI64Big, getI52, getI64Big
d119e50
* removed support for long form automatic marshaler. It has impact to mono_bind_static_method
@pavelsavara
pavelsavaraforce-pushed
the
wasm_resize_and_int64
branch
from
4238f0a to
d119e50CompareMay 13, 2022 21:30
@kg
kg
commented
May 13, 2022

Copy link


Copy Markdown

Contributor
Big fan of the I52 / I64Big split, good idea
@pavelsavara
pavelsavara
commented
May 13, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I implemented feedback from @kg about availability of BigInt and speed of BigInt allocation vs arithmetic.
I also had discussion with @lambdageek about 52 integral bits of Number vs Int64.

There are use-cases where 52 bits are useful, for example for Date.value.
We concluded that emscripten's silent usage of only lower 32 bit is bad.
I also realized that silent usage of lower 52bits could be similarly bad.

So I removed support for marshaling long signature form bind_static_method, which did silent 32bits till now.
This is breaking change, but failing fast should be better than silent data corruption on runtime.
@pavelsavara
pavelsavara
commented
May 19, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I realized that all the other setXXX are also silently trimming bits and not throwing on overflow.

It's like option C) above.

Should I introduce range check to all of them ?
Or remove the range check from Int52 ?

C1) Store it as the memory bits were double ?

C2) Mask any exponent bits and store it as is ?

F) round it to next int, convert NaN to 0, Number.POSITIVE_INFINITY to long.MaxValue ?
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
This looks great, but we should make sure the C# -> JS path handles longs correctly (I think we just need to update the unbox primitive stuff to intentionally work in terms of I52 and throw an exception when unboxing if the long is too large)
I think we never had Number -> long conversion on mono_bind_static_method. I added test for it.
@pavelsavarapavelsavara
changed the title
[wasm] improve I64 memory access[wasm] improve memory access and marshaling range checksMay 19, 2022
@pavelsavara
- fixed marshaling of uint32, uint16 and byte to be unsigned
7982e54
- implemented range check on all set memory operations
- implemented also uint52
- differentiated bool marshaling because it shoud have different validation and message
@pavelsavara
inlined asserts
3e20335
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
Should I introduce range check to all of them ?
We agreed with @kg to range-check them all.

That forced me to fix broken marshaling of unsigned types and bool.

I also implemented uint52.

And I implemented assert inlining, to make sure it doesn't allocate closure.
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
May 19, 2022

Copy link


Copy Markdown


Azure Pipelines failed to run 1 pipeline(s).
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
May 19, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
May 19, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
requested a review
from kgMay 19, 2022 19:18
kg
kg
reviewed
May 19, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
Outdated

@pavelsavara
pavelsavara
requested a review
from kgMay 20, 2022 09:02
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
kg
kg
approved these changes
May 20, 2022
View reviewed changes
@kg
kg
merged commit e7886b2
into
dotnet:mainMay 20, 2022
@pavelsavara
pavelsavara
commented
May 23, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@SamMonoRTSamMonoRT
mentioned this pull request
Jun 7, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Jun 22, 2022
@pavelsavara
pavelsavara
deleted the

wasm_resize_and_int64

branch
July 14, 2022 20:46
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarAwaiting requested review from marek-safar
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@lambdageeklambdageekAwaiting requested review from lambdageek

1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects


None yet


Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelsavara@lewing@kg

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[wasm] improve memory access and marshaling range checks by pavelsavara · Pull Request #64845 · dotnet/runtime · GitHub
Skip to content
[wasm] improve memory access and marshaling range checks - #64845
Merged
kg merged 13 commits into
dotnet:mainfrom 
pavelsavara:wasm_resize_and_int64
May 20, 2022
Merged
[wasm] improve memory access and marshaling range checks#64845
kg merged 13 commits into
dotnet:mainfrom 
pavelsavara:wasm_resize_and_int64
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Feb 5, 2022•

edited

Loading

Copy link


Copy Markdown

Member
  • capture updateGlobalBufferAndViews
  • remove setI64, getI64
  • add setI52, getI52, getU52, setU52
  • add getI64Big, setI64Big
  • change bind_static_method to use int52 with l signature.
  • inlined JS asserts
  • fixed existing binding for unsigned types
  • implemented range validations for all memory access and interop
@pavelsavarapavelsavara
added this to the 7.0.0 milestone
Feb 5, 2022
@ghost
ghost
commented
Feb 5, 2022

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • capture updateGlobalBufferAndViews
  • improve setI64, getI64
  • add getI64Big, setI64Big
  • fix StringDecoder root and hashtable access
Author:pavelsavara
Assignees:-
Labels:
arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone:7.0.0
@ghostghost
assigned pavelsavaraFeb 5, 2022
@pavelsavara
pavelsavara
requested review from
kg and lewingFebruary 5, 2022 11:38
@pavelsavara
pavelsavara
commented
Feb 5, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Feb 5, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Feb 5, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/exports.ts
Outdated

kg
kg
reviewed
Feb 5, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
Outdated

@pavelsavara
pavelsavara
commented
Feb 5, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Feb 5, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Feb 6, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
Outdated

@lewing
lewing
commented
Mar 25, 2022

Copy link


Copy Markdown

Member
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Mar 25, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
pavelsavara
pavelsavara
commented
Mar 28, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
Outdated

@pavelsavara
pavelsavara
marked this pull request as draft
March 31, 2022 17:10
@ghost
ghost
commented
Apr 15, 2022

Copy link


Copy Markdown

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.
@ghost
ghost
commented
Apr 30, 2022

Copy link


Copy Markdown

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.
@ghostghost
closed this
Apr 30, 2022
@ghostghost
removed
the 
no-recent-activity

label
May 12, 2022
@pavelsavarapavelsavara
mentioned this pull request
May 12, 2022
 Merged

@pavelsavara
* new memory accessors setI52, setI64Big, getI52, getI64Big
d119e50
* removed support for long form automatic marshaler. It has impact to mono_bind_static_method
@pavelsavara
pavelsavaraforce-pushed
the
wasm_resize_and_int64
branch
from
4238f0a to
d119e50CompareMay 13, 2022 21:30
@kg
kg
commented
May 13, 2022

Copy link


Copy Markdown

Contributor
Big fan of the I52 / I64Big split, good idea
@pavelsavara
pavelsavara
commented
May 13, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I implemented feedback from @kg about availability of BigInt and speed of BigInt allocation vs arithmetic.
I also had discussion with @lambdageek about 52 integral bits of Number vs Int64.

There are use-cases where 52 bits are useful, for example for Date.value.
We concluded that emscripten's silent usage of only lower 32 bit is bad.
I also realized that silent usage of lower 52bits could be similarly bad.

So I removed support for marshaling long signature form bind_static_method, which did silent 32bits till now.
This is breaking change, but failing fast should be better than silent data corruption on runtime.
@pavelsavara
pavelsavara
commented
May 19, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I realized that all the other setXXX are also silently trimming bits and not throwing on overflow.

It's like option C) above.

Should I introduce range check to all of them ?
Or remove the range check from Int52 ?

C1) Store it as the memory bits were double ?

C2) Mask any exponent bits and store it as is ?

F) round it to next int, convert NaN to 0, Number.POSITIVE_INFINITY to long.MaxValue ?
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
This looks great, but we should make sure the C# -> JS path handles longs correctly (I think we just need to update the unbox primitive stuff to intentionally work in terms of I52 and throw an exception when unboxing if the long is too large)
I think we never had Number -> long conversion on mono_bind_static_method. I added test for it.
@pavelsavarapavelsavara
changed the title
[wasm] improve I64 memory access[wasm] improve memory access and marshaling range checksMay 19, 2022
@pavelsavara
- fixed marshaling of uint32, uint16 and byte to be unsigned
7982e54
- implemented range check on all set memory operations
- implemented also uint52
- differentiated bool marshaling because it shoud have different validation and message
@pavelsavara
inlined asserts
3e20335
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
Should I introduce range check to all of them ?
We agreed with @kg to range-check them all.

That forced me to fix broken marshaling of unsigned types and bool.

I also implemented uint52.

And I implemented assert inlining, to make sure it doesn't allocate closure.
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
May 19, 2022

Copy link


Copy Markdown


Azure Pipelines failed to run 1 pipeline(s).
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
May 19, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
May 19, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
requested a review
from kgMay 19, 2022 19:18
kg
kg
reviewed
May 19, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
Outdated

@pavelsavara
pavelsavara
requested a review
from kgMay 20, 2022 09:02
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
kg
kg
approved these changes
May 20, 2022
View reviewed changes
@kg
kg
merged commit e7886b2
into
dotnet:mainMay 20, 2022
@pavelsavara
pavelsavara
commented
May 23, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@SamMonoRTSamMonoRT
mentioned this pull request
Jun 7, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Jun 22, 2022
@pavelsavara
pavelsavara
deleted the

wasm_resize_and_int64

branch
July 14, 2022 20:46
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarAwaiting requested review from marek-safar
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@lambdageeklambdageekAwaiting requested review from lambdageek

1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects


None yet


Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelsavara@lewing@kg

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[wasm] improve memory access and marshaling range checks by pavelsavara · Pull Request #64845 · dotnet/runtime · GitHub
Skip to content
[wasm] improve memory access and marshaling range checks - #64845
Merged
kg merged 13 commits into
dotnet:mainfrom 
pavelsavara:wasm_resize_and_int64
May 20, 2022
Merged
[wasm] improve memory access and marshaling range checks#64845
kg merged 13 commits into
dotnet:mainfrom 
pavelsavara:wasm_resize_and_int64
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Feb 5, 2022•

edited

Loading

Copy link


Copy Markdown

Member
  • capture updateGlobalBufferAndViews
  • remove setI64, getI64
  • add setI52, getI52, getU52, setU52
  • add getI64Big, setI64Big
  • change bind_static_method to use int52 with l signature.
  • inlined JS asserts
  • fixed existing binding for unsigned types
  • implemented range validations for all memory access and interop
@pavelsavarapavelsavara
added this to the 7.0.0 milestone
Feb 5, 2022
@ghost
ghost
commented
Feb 5, 2022

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • capture updateGlobalBufferAndViews
  • improve setI64, getI64
  • add getI64Big, setI64Big
  • fix StringDecoder root and hashtable access
Author:pavelsavara
Assignees:-
Labels:
arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone:7.0.0
@ghostghost
assigned pavelsavaraFeb 5, 2022
@pavelsavara
pavelsavara
requested review from
kg and lewingFebruary 5, 2022 11:38
@pavelsavara
pavelsavara
commented
Feb 5, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Feb 5, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Feb 5, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/exports.ts
Outdated

kg
kg
reviewed
Feb 5, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
Outdated

@pavelsavara
pavelsavara
commented
Feb 5, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Feb 5, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Feb 6, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
Outdated

@lewing
lewing
commented
Mar 25, 2022

Copy link


Copy Markdown

Member
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Mar 25, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
pavelsavara
pavelsavara
commented
Mar 28, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
Outdated

@pavelsavara
pavelsavara
marked this pull request as draft
March 31, 2022 17:10
@ghost
ghost
commented
Apr 15, 2022

Copy link


Copy Markdown

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.
@ghost
ghost
commented
Apr 30, 2022

Copy link


Copy Markdown

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.
@ghostghost
closed this
Apr 30, 2022
@ghostghost
removed
the 
no-recent-activity

label
May 12, 2022
@pavelsavarapavelsavara
mentioned this pull request
May 12, 2022
 Merged

@pavelsavara
* new memory accessors setI52, setI64Big, getI52, getI64Big
d119e50
* removed support for long form automatic marshaler. It has impact to mono_bind_static_method
@pavelsavara
pavelsavaraforce-pushed
the
wasm_resize_and_int64
branch
from
4238f0a to
d119e50CompareMay 13, 2022 21:30
@kg
kg
commented
May 13, 2022

Copy link


Copy Markdown

Contributor
Big fan of the I52 / I64Big split, good idea
@pavelsavara
pavelsavara
commented
May 13, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I implemented feedback from @kg about availability of BigInt and speed of BigInt allocation vs arithmetic.
I also had discussion with @lambdageek about 52 integral bits of Number vs Int64.

There are use-cases where 52 bits are useful, for example for Date.value.
We concluded that emscripten's silent usage of only lower 32 bit is bad.
I also realized that silent usage of lower 52bits could be similarly bad.

So I removed support for marshaling long signature form bind_static_method, which did silent 32bits till now.
This is breaking change, but failing fast should be better than silent data corruption on runtime.
@pavelsavara
pavelsavara
commented
May 19, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I realized that all the other setXXX are also silently trimming bits and not throwing on overflow.

It's like option C) above.

Should I introduce range check to all of them ?
Or remove the range check from Int52 ?

C1) Store it as the memory bits were double ?

C2) Mask any exponent bits and store it as is ?

F) round it to next int, convert NaN to 0, Number.POSITIVE_INFINITY to long.MaxValue ?
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
This looks great, but we should make sure the C# -> JS path handles longs correctly (I think we just need to update the unbox primitive stuff to intentionally work in terms of I52 and throw an exception when unboxing if the long is too large)
I think we never had Number -> long conversion on mono_bind_static_method. I added test for it.
@pavelsavarapavelsavara
changed the title
[wasm] improve I64 memory access[wasm] improve memory access and marshaling range checksMay 19, 2022
@pavelsavara
- fixed marshaling of uint32, uint16 and byte to be unsigned
7982e54
- implemented range check on all set memory operations
- implemented also uint52
- differentiated bool marshaling because it shoud have different validation and message
@pavelsavara
inlined asserts
3e20335
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
Should I introduce range check to all of them ?
We agreed with @kg to range-check them all.

That forced me to fix broken marshaling of unsigned types and bool.

I also implemented uint52.

And I implemented assert inlining, to make sure it doesn't allocate closure.
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
May 19, 2022

Copy link


Copy Markdown


Azure Pipelines failed to run 1 pipeline(s).
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
May 19, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
May 19, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
requested a review
from kgMay 19, 2022 19:18
kg
kg
reviewed
May 19, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
Outdated

@pavelsavara
pavelsavara
requested a review
from kgMay 20, 2022 09:02
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
kg
kg
approved these changes
May 20, 2022
View reviewed changes
@kg
kg
merged commit e7886b2
into
dotnet:mainMay 20, 2022
@pavelsavara
pavelsavara
commented
May 23, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@SamMonoRTSamMonoRT
mentioned this pull request
Jun 7, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Jun 22, 2022
@pavelsavara
pavelsavara
deleted the

wasm_resize_and_int64

branch
July 14, 2022 20:46
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarAwaiting requested review from marek-safar
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@lambdageeklambdageekAwaiting requested review from lambdageek

1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects


None yet


Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelsavara@lewing@kg

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[wasm] improve memory access and marshaling range checks by pavelsavara · Pull Request #64845 · dotnet/runtime · GitHub
Skip to content
[wasm] improve memory access and marshaling range checks - #64845
Merged
kg merged 13 commits into
dotnet:mainfrom 
pavelsavara:wasm_resize_and_int64
May 20, 2022
Merged
[wasm] improve memory access and marshaling range checks#64845
kg merged 13 commits into
dotnet:mainfrom 
pavelsavara:wasm_resize_and_int64
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Feb 5, 2022•

edited

Loading

Copy link


Copy Markdown

Member
  • capture updateGlobalBufferAndViews
  • remove setI64, getI64
  • add setI52, getI52, getU52, setU52
  • add getI64Big, setI64Big
  • change bind_static_method to use int52 with l signature.
  • inlined JS asserts
  • fixed existing binding for unsigned types
  • implemented range validations for all memory access and interop
@pavelsavarapavelsavara
added this to the 7.0.0 milestone
Feb 5, 2022
@ghost
ghost
commented
Feb 5, 2022

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • capture updateGlobalBufferAndViews
  • improve setI64, getI64
  • add getI64Big, setI64Big
  • fix StringDecoder root and hashtable access
Author:pavelsavara
Assignees:-
Labels:
arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone:7.0.0
@ghostghost
assigned pavelsavaraFeb 5, 2022
@pavelsavara
pavelsavara
requested review from
kg and lewingFebruary 5, 2022 11:38
@pavelsavara
pavelsavara
commented
Feb 5, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Feb 5, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Feb 5, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/exports.ts
Outdated

kg
kg
reviewed
Feb 5, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
Outdated

@pavelsavara
pavelsavara
commented
Feb 5, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Feb 5, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Feb 6, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
Outdated

@lewing
lewing
commented
Mar 25, 2022

Copy link


Copy Markdown

Member
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Mar 25, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
pavelsavara
pavelsavara
commented
Mar 28, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
Outdated

@pavelsavara
pavelsavara
marked this pull request as draft
March 31, 2022 17:10
@ghost
ghost
commented
Apr 15, 2022

Copy link


Copy Markdown

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.
@ghost
ghost
commented
Apr 30, 2022

Copy link


Copy Markdown

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.
@ghostghost
closed this
Apr 30, 2022
@ghostghost
removed
the 
no-recent-activity

label
May 12, 2022
@pavelsavarapavelsavara
mentioned this pull request
May 12, 2022
 Merged

@pavelsavara
* new memory accessors setI52, setI64Big, getI52, getI64Big
d119e50
* removed support for long form automatic marshaler. It has impact to mono_bind_static_method
@pavelsavara
pavelsavaraforce-pushed
the
wasm_resize_and_int64
branch
from
4238f0a to
d119e50CompareMay 13, 2022 21:30
@kg
kg
commented
May 13, 2022

Copy link


Copy Markdown

Contributor
Big fan of the I52 / I64Big split, good idea
@pavelsavara
pavelsavara
commented
May 13, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I implemented feedback from @kg about availability of BigInt and speed of BigInt allocation vs arithmetic.
I also had discussion with @lambdageek about 52 integral bits of Number vs Int64.

There are use-cases where 52 bits are useful, for example for Date.value.
We concluded that emscripten's silent usage of only lower 32 bit is bad.
I also realized that silent usage of lower 52bits could be similarly bad.

So I removed support for marshaling long signature form bind_static_method, which did silent 32bits till now.
This is breaking change, but failing fast should be better than silent data corruption on runtime.
@pavelsavara
pavelsavara
commented
May 19, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I realized that all the other setXXX are also silently trimming bits and not throwing on overflow.

It's like option C) above.

Should I introduce range check to all of them ?
Or remove the range check from Int52 ?

C1) Store it as the memory bits were double ?

C2) Mask any exponent bits and store it as is ?

F) round it to next int, convert NaN to 0, Number.POSITIVE_INFINITY to long.MaxValue ?
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
This looks great, but we should make sure the C# -> JS path handles longs correctly (I think we just need to update the unbox primitive stuff to intentionally work in terms of I52 and throw an exception when unboxing if the long is too large)
I think we never had Number -> long conversion on mono_bind_static_method. I added test for it.
@pavelsavarapavelsavara
changed the title
[wasm] improve I64 memory access[wasm] improve memory access and marshaling range checksMay 19, 2022
@pavelsavara
- fixed marshaling of uint32, uint16 and byte to be unsigned
7982e54
- implemented range check on all set memory operations
- implemented also uint52
- differentiated bool marshaling because it shoud have different validation and message
@pavelsavara
inlined asserts
3e20335
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
Should I introduce range check to all of them ?
We agreed with @kg to range-check them all.

That forced me to fix broken marshaling of unsigned types and bool.

I also implemented uint52.

And I implemented assert inlining, to make sure it doesn't allocate closure.
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
May 19, 2022

Copy link


Copy Markdown


Azure Pipelines failed to run 1 pipeline(s).
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
May 19, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
May 19, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
requested a review
from kgMay 19, 2022 19:18
kg
kg
reviewed
May 19, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
Outdated

@pavelsavara
pavelsavara
requested a review
from kgMay 20, 2022 09:02
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
kg
kg
approved these changes
May 20, 2022
View reviewed changes
@kg
kg
merged commit e7886b2
into
dotnet:mainMay 20, 2022
@pavelsavara
pavelsavara
commented
May 23, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@SamMonoRTSamMonoRT
mentioned this pull request
Jun 7, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Jun 22, 2022
@pavelsavara
pavelsavara
deleted the

wasm_resize_and_int64

branch
July 14, 2022 20:46
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarAwaiting requested review from marek-safar
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@lambdageeklambdageekAwaiting requested review from lambdageek

1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects


None yet


Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelsavara@lewing@kg

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[wasm] improve memory access and marshaling range checks by pavelsavara · Pull Request #64845 · dotnet/runtime · GitHub
Skip to content
[wasm] improve memory access and marshaling range checks - #64845
Merged
kg merged 13 commits into
dotnet:mainfrom 
pavelsavara:wasm_resize_and_int64
May 20, 2022
Merged
[wasm] improve memory access and marshaling range checks#64845
kg merged 13 commits into
dotnet:mainfrom 
pavelsavara:wasm_resize_and_int64
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Feb 5, 2022•

edited

Loading

Copy link


Copy Markdown

Member
  • capture updateGlobalBufferAndViews
  • remove setI64, getI64
  • add setI52, getI52, getU52, setU52
  • add getI64Big, setI64Big
  • change bind_static_method to use int52 with l signature.
  • inlined JS asserts
  • fixed existing binding for unsigned types
  • implemented range validations for all memory access and interop
@pavelsavarapavelsavara
added this to the 7.0.0 milestone
Feb 5, 2022
@ghost
ghost
commented
Feb 5, 2022

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • capture updateGlobalBufferAndViews
  • improve setI64, getI64
  • add getI64Big, setI64Big
  • fix StringDecoder root and hashtable access
Author:pavelsavara
Assignees:-
Labels:
arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone:7.0.0
@ghostghost
assigned pavelsavaraFeb 5, 2022
@pavelsavara
pavelsavara
requested review from
kg and lewingFebruary 5, 2022 11:38
@pavelsavara
pavelsavara
commented
Feb 5, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Feb 5, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Feb 5, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/exports.ts
Outdated

kg
kg
reviewed
Feb 5, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
Outdated

@pavelsavara
pavelsavara
commented
Feb 5, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Feb 5, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Feb 6, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
Outdated

@lewing
lewing
commented
Mar 25, 2022

Copy link


Copy Markdown

Member
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Mar 25, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
pavelsavara
pavelsavara
commented
Mar 28, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
Outdated

@pavelsavara
pavelsavara
marked this pull request as draft
March 31, 2022 17:10
@ghost
ghost
commented
Apr 15, 2022

Copy link


Copy Markdown

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.
@ghost
ghost
commented
Apr 30, 2022

Copy link


Copy Markdown

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.
@ghostghost
closed this
Apr 30, 2022
@ghostghost
removed
the 
no-recent-activity

label
May 12, 2022
@pavelsavarapavelsavara
mentioned this pull request
May 12, 2022
 Merged

@pavelsavara
* new memory accessors setI52, setI64Big, getI52, getI64Big
d119e50
* removed support for long form automatic marshaler. It has impact to mono_bind_static_method
@pavelsavara
pavelsavaraforce-pushed
the
wasm_resize_and_int64
branch
from
4238f0a to
d119e50CompareMay 13, 2022 21:30
@kg
kg
commented
May 13, 2022

Copy link


Copy Markdown

Contributor
Big fan of the I52 / I64Big split, good idea
@pavelsavara
pavelsavara
commented
May 13, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I implemented feedback from @kg about availability of BigInt and speed of BigInt allocation vs arithmetic.
I also had discussion with @lambdageek about 52 integral bits of Number vs Int64.

There are use-cases where 52 bits are useful, for example for Date.value.
We concluded that emscripten's silent usage of only lower 32 bit is bad.
I also realized that silent usage of lower 52bits could be similarly bad.

So I removed support for marshaling long signature form bind_static_method, which did silent 32bits till now.
This is breaking change, but failing fast should be better than silent data corruption on runtime.
@pavelsavara
pavelsavara
commented
May 19, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I realized that all the other setXXX are also silently trimming bits and not throwing on overflow.

It's like option C) above.

Should I introduce range check to all of them ?
Or remove the range check from Int52 ?

C1) Store it as the memory bits were double ?

C2) Mask any exponent bits and store it as is ?

F) round it to next int, convert NaN to 0, Number.POSITIVE_INFINITY to long.MaxValue ?
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
This looks great, but we should make sure the C# -> JS path handles longs correctly (I think we just need to update the unbox primitive stuff to intentionally work in terms of I52 and throw an exception when unboxing if the long is too large)
I think we never had Number -> long conversion on mono_bind_static_method. I added test for it.
@pavelsavarapavelsavara
changed the title
[wasm] improve I64 memory access[wasm] improve memory access and marshaling range checksMay 19, 2022
@pavelsavara
- fixed marshaling of uint32, uint16 and byte to be unsigned
7982e54
- implemented range check on all set memory operations
- implemented also uint52
- differentiated bool marshaling because it shoud have different validation and message
@pavelsavara
inlined asserts
3e20335
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
Should I introduce range check to all of them ?
We agreed with @kg to range-check them all.

That forced me to fix broken marshaling of unsigned types and bool.

I also implemented uint52.

And I implemented assert inlining, to make sure it doesn't allocate closure.
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
May 19, 2022

Copy link


Copy Markdown


Azure Pipelines failed to run 1 pipeline(s).
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
May 19, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
May 19, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
requested a review
from kgMay 19, 2022 19:18
kg
kg
reviewed
May 19, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
Outdated

@pavelsavara
pavelsavara
requested a review
from kgMay 20, 2022 09:02
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
kg
kg
approved these changes
May 20, 2022
View reviewed changes
@kg
kg
merged commit e7886b2
into
dotnet:mainMay 20, 2022
@pavelsavara
pavelsavara
commented
May 23, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@SamMonoRTSamMonoRT
mentioned this pull request
Jun 7, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Jun 22, 2022
@pavelsavara
pavelsavara
deleted the

wasm_resize_and_int64

branch
July 14, 2022 20:46
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarAwaiting requested review from marek-safar
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@lambdageeklambdageekAwaiting requested review from lambdageek

1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects


None yet


Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelsavara@lewing@kg

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[wasm] improve memory access and marshaling range checks by pavelsavara · Pull Request #64845 · dotnet/runtime · GitHub
Skip to content
[wasm] improve memory access and marshaling range checks - #64845
Merged
kg merged 13 commits into
dotnet:mainfrom 
pavelsavara:wasm_resize_and_int64
May 20, 2022
Merged
[wasm] improve memory access and marshaling range checks#64845
kg merged 13 commits into
dotnet:mainfrom 
pavelsavara:wasm_resize_and_int64
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Feb 5, 2022•

edited

Loading

Copy link


Copy Markdown

Member
  • capture updateGlobalBufferAndViews
  • remove setI64, getI64
  • add setI52, getI52, getU52, setU52
  • add getI64Big, setI64Big
  • change bind_static_method to use int52 with l signature.
  • inlined JS asserts
  • fixed existing binding for unsigned types
  • implemented range validations for all memory access and interop
@pavelsavarapavelsavara
added this to the 7.0.0 milestone
Feb 5, 2022
@ghost
ghost
commented
Feb 5, 2022

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • capture updateGlobalBufferAndViews
  • improve setI64, getI64
  • add getI64Big, setI64Big
  • fix StringDecoder root and hashtable access
Author:pavelsavara
Assignees:-
Labels:
arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone:7.0.0
@ghostghost
assigned pavelsavaraFeb 5, 2022
@pavelsavara
pavelsavara
requested review from
kg and lewingFebruary 5, 2022 11:38
@pavelsavara
pavelsavara
commented
Feb 5, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Feb 5, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Feb 5, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/exports.ts
Outdated

kg
kg
reviewed
Feb 5, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
Outdated

@pavelsavara
pavelsavara
commented
Feb 5, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Feb 5, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Feb 6, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
Outdated

@lewing
lewing
commented
Mar 25, 2022

Copy link


Copy Markdown

Member
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Mar 25, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
pavelsavara
pavelsavara
commented
Mar 28, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
Outdated

@pavelsavara
pavelsavara
marked this pull request as draft
March 31, 2022 17:10
@ghost
ghost
commented
Apr 15, 2022

Copy link


Copy Markdown

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.
@ghost
ghost
commented
Apr 30, 2022

Copy link


Copy Markdown

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.
@ghostghost
closed this
Apr 30, 2022
@ghostghost
removed
the 
no-recent-activity

label
May 12, 2022
@pavelsavarapavelsavara
mentioned this pull request
May 12, 2022
 Merged

@pavelsavara
* new memory accessors setI52, setI64Big, getI52, getI64Big
d119e50
* removed support for long form automatic marshaler. It has impact to mono_bind_static_method
@pavelsavara
pavelsavaraforce-pushed
the
wasm_resize_and_int64
branch
from
4238f0a to
d119e50CompareMay 13, 2022 21:30
@kg
kg
commented
May 13, 2022

Copy link


Copy Markdown

Contributor
Big fan of the I52 / I64Big split, good idea
@pavelsavara
pavelsavara
commented
May 13, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I implemented feedback from @kg about availability of BigInt and speed of BigInt allocation vs arithmetic.
I also had discussion with @lambdageek about 52 integral bits of Number vs Int64.

There are use-cases where 52 bits are useful, for example for Date.value.
We concluded that emscripten's silent usage of only lower 32 bit is bad.
I also realized that silent usage of lower 52bits could be similarly bad.

So I removed support for marshaling long signature form bind_static_method, which did silent 32bits till now.
This is breaking change, but failing fast should be better than silent data corruption on runtime.
@pavelsavara
pavelsavara
commented
May 19, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I realized that all the other setXXX are also silently trimming bits and not throwing on overflow.

It's like option C) above.

Should I introduce range check to all of them ?
Or remove the range check from Int52 ?

C1) Store it as the memory bits were double ?

C2) Mask any exponent bits and store it as is ?

F) round it to next int, convert NaN to 0, Number.POSITIVE_INFINITY to long.MaxValue ?
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
This looks great, but we should make sure the C# -> JS path handles longs correctly (I think we just need to update the unbox primitive stuff to intentionally work in terms of I52 and throw an exception when unboxing if the long is too large)
I think we never had Number -> long conversion on mono_bind_static_method. I added test for it.
@pavelsavarapavelsavara
changed the title
[wasm] improve I64 memory access[wasm] improve memory access and marshaling range checksMay 19, 2022
@pavelsavara
- fixed marshaling of uint32, uint16 and byte to be unsigned
7982e54
- implemented range check on all set memory operations
- implemented also uint52
- differentiated bool marshaling because it shoud have different validation and message
@pavelsavara
inlined asserts
3e20335
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
Should I introduce range check to all of them ?
We agreed with @kg to range-check them all.

That forced me to fix broken marshaling of unsigned types and bool.

I also implemented uint52.

And I implemented assert inlining, to make sure it doesn't allocate closure.
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
May 19, 2022

Copy link


Copy Markdown


Azure Pipelines failed to run 1 pipeline(s).
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
May 19, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
May 19, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
requested a review
from kgMay 19, 2022 19:18
kg
kg
reviewed
May 19, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
Outdated

@pavelsavara
pavelsavara
requested a review
from kgMay 20, 2022 09:02
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
kg
kg
approved these changes
May 20, 2022
View reviewed changes
@kg
kg
merged commit e7886b2
into
dotnet:mainMay 20, 2022
@pavelsavara
pavelsavara
commented
May 23, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@SamMonoRTSamMonoRT
mentioned this pull request
Jun 7, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Jun 22, 2022
@pavelsavara
pavelsavara
deleted the

wasm_resize_and_int64

branch
July 14, 2022 20:46
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarAwaiting requested review from marek-safar
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@lambdageeklambdageekAwaiting requested review from lambdageek

1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects


None yet


Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelsavara@lewing@kg

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[wasm] improve memory access and marshaling range checks by pavelsavara · Pull Request #64845 · dotnet/runtime · GitHub
Skip to content
[wasm] improve memory access and marshaling range checks - #64845
Merged
kg merged 13 commits into
dotnet:mainfrom 
pavelsavara:wasm_resize_and_int64
May 20, 2022
Merged
[wasm] improve memory access and marshaling range checks#64845
kg merged 13 commits into
dotnet:mainfrom 
pavelsavara:wasm_resize_and_int64
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Feb 5, 2022•

edited

Loading

Copy link


Copy Markdown

Member
  • capture updateGlobalBufferAndViews
  • remove setI64, getI64
  • add setI52, getI52, getU52, setU52
  • add getI64Big, setI64Big
  • change bind_static_method to use int52 with l signature.
  • inlined JS asserts
  • fixed existing binding for unsigned types
  • implemented range validations for all memory access and interop
@pavelsavarapavelsavara
added this to the 7.0.0 milestone
Feb 5, 2022
@ghost
ghost
commented
Feb 5, 2022

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • capture updateGlobalBufferAndViews
  • improve setI64, getI64
  • add getI64Big, setI64Big
  • fix StringDecoder root and hashtable access
Author:pavelsavara
Assignees:-
Labels:
arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone:7.0.0
@ghostghost
assigned pavelsavaraFeb 5, 2022
@pavelsavara
pavelsavara
requested review from
kg and lewingFebruary 5, 2022 11:38
@pavelsavara
pavelsavara
commented
Feb 5, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Feb 5, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Feb 5, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/exports.ts
Outdated

kg
kg
reviewed
Feb 5, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
Outdated

@pavelsavara
pavelsavara
commented
Feb 5, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Feb 5, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Feb 6, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
Outdated

@lewing
lewing
commented
Mar 25, 2022

Copy link


Copy Markdown

Member
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Mar 25, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
pavelsavara
pavelsavara
commented
Mar 28, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
Outdated

@pavelsavara
pavelsavara
marked this pull request as draft
March 31, 2022 17:10
@ghost
ghost
commented
Apr 15, 2022

Copy link


Copy Markdown

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.
@ghost
ghost
commented
Apr 30, 2022

Copy link


Copy Markdown

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.
@ghostghost
closed this
Apr 30, 2022
@ghostghost
removed
the 
no-recent-activity

label
May 12, 2022
@pavelsavarapavelsavara
mentioned this pull request
May 12, 2022
 Merged

@pavelsavara
* new memory accessors setI52, setI64Big, getI52, getI64Big
d119e50
* removed support for long form automatic marshaler. It has impact to mono_bind_static_method
@pavelsavara
pavelsavaraforce-pushed
the
wasm_resize_and_int64
branch
from
4238f0a to
d119e50CompareMay 13, 2022 21:30
@kg
kg
commented
May 13, 2022

Copy link


Copy Markdown

Contributor
Big fan of the I52 / I64Big split, good idea
@pavelsavara
pavelsavara
commented
May 13, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I implemented feedback from @kg about availability of BigInt and speed of BigInt allocation vs arithmetic.
I also had discussion with @lambdageek about 52 integral bits of Number vs Int64.

There are use-cases where 52 bits are useful, for example for Date.value.
We concluded that emscripten's silent usage of only lower 32 bit is bad.
I also realized that silent usage of lower 52bits could be similarly bad.

So I removed support for marshaling long signature form bind_static_method, which did silent 32bits till now.
This is breaking change, but failing fast should be better than silent data corruption on runtime.
@pavelsavara
pavelsavara
commented
May 19, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I realized that all the other setXXX are also silently trimming bits and not throwing on overflow.

It's like option C) above.

Should I introduce range check to all of them ?
Or remove the range check from Int52 ?

C1) Store it as the memory bits were double ?

C2) Mask any exponent bits and store it as is ?

F) round it to next int, convert NaN to 0, Number.POSITIVE_INFINITY to long.MaxValue ?
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
This looks great, but we should make sure the C# -> JS path handles longs correctly (I think we just need to update the unbox primitive stuff to intentionally work in terms of I52 and throw an exception when unboxing if the long is too large)
I think we never had Number -> long conversion on mono_bind_static_method. I added test for it.
@pavelsavarapavelsavara
changed the title
[wasm] improve I64 memory access[wasm] improve memory access and marshaling range checksMay 19, 2022
@pavelsavara
- fixed marshaling of uint32, uint16 and byte to be unsigned
7982e54
- implemented range check on all set memory operations
- implemented also uint52
- differentiated bool marshaling because it shoud have different validation and message
@pavelsavara
inlined asserts
3e20335
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
Should I introduce range check to all of them ?
We agreed with @kg to range-check them all.

That forced me to fix broken marshaling of unsigned types and bool.

I also implemented uint52.

And I implemented assert inlining, to make sure it doesn't allocate closure.
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
May 19, 2022

Copy link


Copy Markdown


Azure Pipelines failed to run 1 pipeline(s).
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
May 19, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
May 19, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
requested a review
from kgMay 19, 2022 19:18
kg
kg
reviewed
May 19, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
Outdated

@pavelsavara
pavelsavara
requested a review
from kgMay 20, 2022 09:02
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/memory.ts
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
kg
kg
reviewed
May 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/rollup.config.js
kg
kg
approved these changes
May 20, 2022
View reviewed changes
@kg
kg
merged commit e7886b2
into
dotnet:mainMay 20, 2022
@pavelsavara
pavelsavara
commented
May 23, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@SamMonoRTSamMonoRT
mentioned this pull request
Jun 7, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Jun 22, 2022
@pavelsavara
pavelsavara
deleted the

wasm_resize_and_int64

branch
July 14, 2022 20:46
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarAwaiting requested review from marek-safar
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@lambdageeklambdageekAwaiting requested review from lambdageek

1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects


None yet


Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelsavara@lewing@kg