Skip to content

Turn off -ffp-contract on Unix - #64847

Merged
jkotas merged 1 commit into
dotnet:mainfrom
am11:feature/build/native
Feb 7, 2022
Merged

Turn off -ffp-contract on Unix#64847
jkotas merged 1 commit into
dotnet:mainfrom
am11:feature/build/native

Conversation

@am11

@am11am11 commented Feb 5, 2022

Copy link
Copy Markdown
Member

Fixes#64604

@ghostghost added area-Infrastructure-coreclr Only use for closed issues community-contribution Indicates that the PR has been added by a community member labels Feb 5, 2022
@ghost

ghost commented Feb 5, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #64604

Author:am11
Assignees:-
Labels:

area-Infrastructure-coreclr

Milestone:-

@am11
am11 marked this pull request as ready for review February 5, 2022 16:28
@am11

am11 commented Feb 5, 2022

Copy link
Copy Markdown
MemberAuthor

cc @tannergooding, @lambdageek, applied the option globally to both clang and gcc (in mono's cmake config, the variable GCC is on for gcc and clang as well, which is a bit confusing).

@jkotasjkotas added area-System.Numerics and removed area-Infrastructure-coreclr Only use for closed issues labels Feb 5, 2022
@ghost

ghost commented Feb 6, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #64604

Author:am11
Assignees:-
Labels:

area-System.Numerics, area-Infrastructure-coreclr, community-contribution

Milestone:-

@jkotas
jkotas merged commit 805a5e4 into dotnet:mainFeb 7, 2022
@am11
am11 deleted the feature/build/native branch February 7, 2022 17:48
@am11

am11 commented Feb 7, 2022

Copy link
Copy Markdown
MemberAuthor

Next outerloop run completed, https://github.com/dotnet/runtime/runs/5100686895, seems no failures due to this change, but I am not completely sure about NFloatToIntPtr one: #64467 (comment).

I have opened a few issues for the other failures noticed in the run.

@ghostghost locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageeklambdageeklambdageek approved these changes
@tannergoodingtannergoodingtannergooding approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

No one assigned

Labels

area-System.Numericscommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ensure we set -ffp-contract=off on GCC

4 participants

@am11@lambdageek@tannergooding@jkotas