Skip to content

Delete ReflectionModule::m_pCreatingAssembly and PEAssembly::m_creator - #64865

Merged
jkotas merged 7 commits into
dotnet:mainfrom
jkotas:cleanup
Feb 7, 2022
Merged

Delete ReflectionModule::m_pCreatingAssembly and PEAssembly::m_creator#64865
jkotas merged 7 commits into
dotnet:mainfrom
jkotas:cleanup

Conversation

@jkotas

@jkotasjkotas commented Feb 6, 2022

Copy link
Copy Markdown
Member

No description provided.

@jkotas
jkotas requested a review from VSadovFebruary 6, 2022 05:01
@ghostghost added the area-AssemblyLoader-coreclr only use for closed issues label Feb 6, 2022
@ghostghost assigned jkotasFeb 6, 2022
@ghost

ghost commented Feb 6, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:jkotas
Assignees:-
Labels:

area-AssemblyLoader-coreclr

Milestone:-

jkotas
jkotas commented Feb 6, 2022
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/AssemblyBuilder.cs
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

// For each dynamic assembly there will be two AssemblyBuilder objects: the "internal"

@jkotasjkotasFeb 6, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obsolete comment

jkotas
jkotas commented Feb 6, 2022
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/AssemblyBuilder.cs Outdated
@jkotas

jkotas commented Feb 6, 2022

Copy link
Copy Markdown
MemberAuthor

The test failure is #61359

VSadov
VSadov reviewed Feb 6, 2022
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/AssemblyBuilder.cs Outdated
VSadov
VSadov reviewed Feb 6, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/peassembly.cpp Outdated
VSadov
VSadov approved these changes Feb 6, 2022
View reviewed changes

@VSadovVSadov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

@jkotas
jkotas merged commit 3c43ef6 into dotnet:mainFeb 7, 2022
@jkotas
jkotas deleted the cleanup branch February 7, 2022 22:29
@ghostghost locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@VSadovVSadovVSadov approved these changes

Assignees

@jkotasjkotas

Labels

area-AssemblyLoader-coreclronly use for closed issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jkotas@VSadov