Uh oh!
There was an error while loading. Please reload this page.
[release/6.0][wasm] Remove USE_ZLIB=1 and include the sources instead - #64907
Merged
Conversation
ghost
commented
Feb 7, 2022
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
akoeplinger
marked this pull request as ready for review
February 7, 2022 16:15
akoeplinger
requested review from
lewing and radical
and removed request for
marek-safarFebruary 7, 2022 16:15
Backport of dotnet#64628 to release/6.0
lewing
approved these changes
Feb 8, 2022
danmoseley
commented
Feb 10, 2022
Contributor
Does this mean src/mono/mono/zlib/* are dead? If so there's an advantage in deleting them, because they are still scanned for hypothetical future vulnerabilities etc. |
lewing
commented
Feb 10, 2022
Member
Unfortunately I believe that is yet another zlib. |
danmoseley
commented
Feb 10, 2022
Contributor
Ah, I see it was cleaned up in main already. 0e499ac |
safern
commented
Feb 11, 2022
Member
@mmitche this PR was marked as 6.0.3 on yesterday's tactics meeting, should we still merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #64628 to release/6.0
/cc @lewing@radical
Customer Impact
During the dotnet/runtime build Emscripten would download and cache zlib sources for wasm builds that set
USE_ZLIB=1. As we saw in #62553 this can lead the failures if that download fails and also introduces an unnecessary dependency that we can avoid since we already have the sources in the repo.Note: in main the zlib sources were refactored to not be in a Windows-specific folder path, but for release/6.0 including them from the Windows-specific path is less churn.
Testing
Manual and CI testing.
Risk
Low. We're replacing the zlib sources that emscripten downloads with the (identical) sources we already have in the repo.