Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] [mono] Remove OP_FCONV_TO_U opcode - #64914
Merged
Merged
Conversation
* Emit OP_FCONV_TO_U8/U4 instead of OP_FCONV_TO_U. * Remove OP_FCONV_TO_U implementations across all back ends. * Remove duplicated mono_fconv_u8/u4 icall wrappers. * Fixes#64570
github-actionsBot
requested review from
BrzVlad, EgorBo, SamMonoRT, imhameed, lambdageek and vargaz
as code ownersFebruary 7, 2022 16:25
ghost
commented
Feb 7, 2022
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
lewing
approved these changes
Feb 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #64618 to release/6.0
/cc @akoeplinger@uweigand@lambdageek
Customer Impact
This is necessary for the nfloat changes from #64556 or we'd run into failures on some platforms like s390x.
Testing
CI testing.
Risk
Low. This won't cause a change in behavior on arm or intel. It just makes the code consistent on all the platforms.