Skip to content

Optimize StringBuilder.Insert. - #64922

Merged
tannergooding merged 2 commits into
dotnet:mainfrom
teo-tsirpanis:stringbuilder-insert-optimize
Feb 10, 2022
Merged

Optimize StringBuilder.Insert.#64922
tannergooding merged 2 commits into
dotnet:mainfrom
teo-tsirpanis:stringbuilder-insert-optimize

Conversation

@teo-tsirpanis

@teo-tsirpanisteo-tsirpanis commented Feb 7, 2022

Copy link
Copy Markdown
Contributor

The character array overload calls the ReadOnlySpan overload, and the overloads of primitives call a private helper function that takes advantage of ISpanFormattable.

Salvaged from #58907.

@teo-tsirpanis
Optimize StringBuilder.Insert.
7e699c9
The character array overload calls the ReadOnlySpan overload, and the overloads of primitives call a private helper function that takes advantage of ISpanFormattable.
@ghost

ghost commented Feb 7, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghostghost added the community-contribution Indicates that the PR has been added by a community member label Feb 7, 2022
stephentoub
stephentoub reviewed Feb 8, 2022
View reviewed changes

@stephentoubstephentoub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The changes overall look good, but there are some test failures to be looked at around corner case error handling.

danmoseley
danmoseley reviewed Feb 8, 2022
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Text/StringBuilder.cs
@runfoapprunfoappBot mentioned this pull request Feb 8, 2022
Closed
@teo-tsirpanis

teo-tsirpanis commented Feb 8, 2022

Copy link
Copy Markdown
ContributorAuthor

Tests seem to pass @stephentoub.

stephentoub
stephentoub approved these changes Feb 8, 2022
View reviewed changes

@stephentoubstephentoub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghost

ghost commented Feb 10, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

The character array overload calls the ReadOnlySpan overload, and the overloads of primitives call a private helper function that takes advantage of ISpanFormattable.

Salvaged from #58907.

Author:teo-tsirpanis
Assignees:-
Labels:

area-System.Runtime, community-contribution

Milestone:-

@tannergooding
tannergooding merged commit 68bdfd3 into dotnet:mainFeb 10, 2022
@teo-tsirpanis
teo-tsirpanis deleted the stringbuilder-insert-optimize branch February 10, 2022 16:10
@ghostghost locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes
@tannergoodingtannergoodingtannergooding approved these changes
+1 more reviewer
@danmoseleydanmoseleydanmoseley left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Runtimecommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@teo-tsirpanis@stephentoub@danmoseley@tannergooding