Skip to content

Override DictionaryEntry.ToString to match KeyValuePair.ToString - #64959

Merged
jeffhandley merged 3 commits into
dotnet:mainfrom
jeffhandley:jeffhandley/59292-de-tostring
Feb 9, 2022
Merged

Override DictionaryEntry.ToString to match KeyValuePair.ToString#64959
jeffhandley merged 3 commits into
dotnet:mainfrom
jeffhandley:jeffhandley/59292-de-tostring

Conversation

@jeffhandley

@jeffhandleyjeffhandley commented Feb 8, 2022

Copy link
Copy Markdown
Member

Fixes#59292 by reusing the ToString implementation from KeyValuePair. This emits the unescaped, non-truncated key and value string representations.

@jeffhandleyjeffhandley added this to the 7.0.0 milestone Feb 8, 2022
@ghost

ghost commented Feb 8, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #59292 by reusing the ToString implementation from KeyValuePair. This emits the unescaped, non-truncated key and value string representations.

Author:jeffhandley
Assignees:-
Labels:

area-System.Collections

Milestone:7.0.0

@ghostghost assigned jeffhandleyFeb 8, 2022
stephentoub
stephentoub reviewed Feb 8, 2022
View reviewed changes
Comment threadsrc/libraries/Common/tests/System/Collections/DictionaryEntry.Tests.cs
stephentoub
stephentoub reviewed Feb 8, 2022
View reviewed changes
Comment threadsrc/libraries/Common/tests/System/Collections/DictionaryEntry.Tests.cs Outdated
This was referenced Feb 8, 2022
Closed
Closed
@jeffhandley

jeffhandley commented Feb 9, 2022

Copy link
Copy Markdown
MemberAuthor

Thanks for the var ➡️ string commit, @stephentoub.

@jeffhandley
jeffhandley merged commit 0c28639 into dotnet:mainFeb 9, 2022
@jeffhandley
jeffhandley deleted the jeffhandley/59292-de-tostring branch February 9, 2022 02:14
@ghostghost locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes
@eiriktsarpaliseiriktsarpaliseiriktsarpalis approved these changes

Assignees

@jeffhandleyjeffhandley

Labels

area-System.Collections

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Implement ToString() on System.Collections.DictionaryEntry

3 participants

@jeffhandley@stephentoub@eiriktsarpalis