Uh oh!
There was an error while loading. Please reload this page.
Make System.Math/MathF.Truncate an intrinsic - #65014
Merged
Merged
Conversation
ghost
commented
Feb 8, 2022
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsMakes Truncate emit round with truncate mode on xarch and frintz on aarch64. Based off current handling for Ceiling. Fixes #56931
|
MichalPetrykaforce-pushed
the
intrinsic-truncate
branch
from
February 8, 2022 20:51
3c5c520 to
ab55a47CompareMichalPetryka
commented
Feb 8, 2022
ContributorAuthor
@tannergooding asked me to revert the fcalls and add back the managed method instead on discord, will handle it tomorrow. |
MichalPetrykaforce-pushed
the
intrinsic-truncate
branch
from
February 9, 2022 13:48
ab55a47 to
5e1ff68CompareMichalPetrykaforce-pushed
the
intrinsic-truncate
branch
from
February 9, 2022 14:27
5e1ff68 to
196eafeCompareMichalPetryka
marked this pull request as ready for review
February 9, 2022 18:00
MichalPetryka
commented
Feb 9, 2022
ContributorAuthor
Test failures seem unrelated, marking as ready for review. |
tannergooding
approved these changes
Feb 11, 2022
tannergooding
commented
Feb 11, 2022
Member
CC. @dotnet/jit-contrib; Community PR needs secondary sign-off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes Truncate emit round with truncate mode on xarch and frintz on aarch64.
Based off current handling for Ceiling.
Fixes#56931