Skip to content

[release/6.0] Port ICU tests fix for server core x86 - #65038

Merged
safern merged 3 commits into
dotnet:release/6.0from
safern:PortIcuTestsFix60
Feb 14, 2022
Merged

[release/6.0] Port ICU tests fix for server core x86#65038
safern merged 3 commits into
dotnet:release/6.0from
safern:PortIcuTestsFix60

Conversation

@safern

@safernsafern commented Feb 9, 2022

Copy link
Copy Markdown
Member

icu is not present on Server Core in the SysWOW64.

Test only change to help get release branch CI green.

Branch is closed at the moment, but this can be merged when it is opened.

@ghostghost assigned safernFeb 9, 2022
@ghost

ghost commented Feb 9, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

icu is not present on Server Core in the SysWOW64.

Test only change to help get release branch CI green.

Branch is closed at the moment, but this can be merged when it is opened.

Author:safern
Assignees:safern
Labels:

area-System.Globalization

Milestone:-

@safernsafern mentioned this pull request Feb 9, 2022
Merged
danmoseley
danmoseley approved these changes Feb 9, 2022
View reviewed changes

@danmoseleydanmoseley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for keeping the tests healthy in servicing branches..

@safern

safern commented Feb 9, 2022

Copy link
Copy Markdown
MemberAuthor

thanks for keeping the tests healthy in servicing branches..

Trying my best, with so many changes it's been a challenge but I think we are getting there.

akoeplinger
akoeplinger reviewed Feb 10, 2022
View reviewed changes
Comment threadsrc/libraries/System.Globalization/tests/IcuTests.cs Outdated
@tarekgh@akoeplinger
Update src/libraries/System.Globalization/tests/IcuTests.cs
d4e6c73
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
@tannergoodingtannergooding mentioned this pull request Feb 11, 2022
Merged
@runfoapprunfoappBot mentioned this pull request Feb 14, 2022
Closed
@safern
safern merged commit 5e65919 into dotnet:release/6.0Feb 14, 2022
@safern
safern deleted the PortIcuTestsFix60 branch February 14, 2022 18:34
@safern

safern commented Feb 14, 2022

Copy link
Copy Markdown
MemberAuthor

Thanks, @akoeplinger for pushing the missing platform detection member.

@eiriktsarpaliseiriktsarpalis mentioned this pull request Feb 25, 2022
Closed
@ericstjericstj mentioned this pull request Mar 11, 2022
Merged
@ghostghost locked as resolved and limited conversation to collaborators Mar 16, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@tarekghtarekghtarekgh approved these changes
+1 more reviewer
@danmoseleydanmoseleydanmoseley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@safernsafern

Labels

area-System.Globalization

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@safern@akoeplinger@danmoseley@tarekgh