Skip to content

[release/6.0] Improve SSL platform detection (#64923) - #65054

Merged
carlossanlop merged 1 commit into
dotnet:release/6.0from
wfurt:platform60
Mar 11, 2022
Merged

[release/6.0] Improve SSL platform detection (#64923)#65054
carlossanlop merged 1 commit into
dotnet:release/6.0from
wfurt:platform60

Conversation

@wfurt

@wfurtwfurt commented Feb 9, 2022

Copy link
Copy Markdown
Member

manual port of #64923 to improve TLS detection on Azure images of Server 2022.
(test only change)

  • CI matrix change: add Windows Server 2022

  • Add registry check for ssl3 - tls1.2 tests

  • Disable TLS1.3 on framework code

  • Fix typo

  • revert queue change

Co-authored-by: Jan Jahoda jajahoda@microsoft.com

@wfurtJan Jahoda
Improve SSL platform detection (dotnet#64923)
3c03fcc
* CI matrix change: add Windows Server 2022
* Add registry check for ssl3 - tls1.2 tests
* Disable TLS1.3 on framework code
* Fix typo
* revert queue change
Co-authored-by: Jan Jahoda <jajahoda@microsoft.com>
@wfurtwfurt added area-System.Net.Security test-enhancement Improvements of test source code labels Feb 9, 2022
@wfurtwfurt self-assigned this Feb 9, 2022
@ghost

ghost commented Feb 9, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

manual port of #64923 to improve TLS detection on Azure images of Server 2022.
(test only change)

  • CI matrix change: add Windows Server 2022

  • Add registry check for ssl3 - tls1.2 tests

  • Disable TLS1.3 on framework code

  • Fix typo

  • revert queue change

Co-authored-by: Jan Jahoda jajahoda@microsoft.com

Author:wfurt
Assignees:wfurt
Labels:

area-System.Net.Security, test enhancement

Milestone:-

@ericstj

ericstj commented Mar 11, 2022•
edited
Loading

Copy link
Copy Markdown
Member

@wfurt is this ready to be merged? Can we get fresh PR validation results and a signoff?

@ericstj

ericstj commented Mar 11, 2022

Copy link
Copy Markdown
Member

/azp run runtime

@azure-pipelines

azure-pipelinesBot commented Mar 11, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop

carlossanlop commented Mar 11, 2022

Copy link
Copy Markdown
Contributor

@wfurt @dotnet/ncl this is an infra change targeting release/6.0. Today is the deadline for merging servicing changes to 6.0. Can someone take a look and confirm it's good to merge and sign off? Otherwise we'll have to wait for the next servicing release.

@wfurt

wfurt commented Mar 11, 2022

Copy link
Copy Markdown
MemberAuthor

This impacts tests. So it depends how much we care about failures. I feel this is ready but my team is probably all off already.

@carlossanlop

carlossanlop commented Mar 11, 2022

Copy link
Copy Markdown
Contributor

Ah my bad, I didn't notice it was test-only. I can sign it off. The CI passed successfully. I'll merge it now.

@carlossanlop
carlossanlop merged commit 76a717c into dotnet:release/6.0Mar 11, 2022
@karelzkarelz added this to the 6.0.x milestone Apr 8, 2022
@ghostghost locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@wfurtwfurt

Labels

area-System.Net.Securitytest-enhancementImprovements of test source code

Projects

None yet

Milestone

6.0.x

Development

Successfully merging this pull request may close these issues.

4 participants

@wfurt@ericstj@carlossanlop@karelz