Skip to content

[release/6.0] Disable ILVerify for source build - #65082

Merged
jeffschwMSFT merged 1 commit into
release/6.0from
backport/pr-64833-to-release/6.0
Feb 10, 2022
Merged

[release/6.0] Disable ILVerify for source build#65082
jeffschwMSFT merged 1 commit into
release/6.0from
backport/pr-64833-to-release/6.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Feb 9, 2022

Copy link
Copy Markdown
Contributor

Backport of #64833 to release/6.0

/cc @jkotas

Customer Impact

Build break in source build introduced by .NET SDK picking up a newer version of System.Command line library that conflicts with the version used by ILVerify tool. The fix is to disable building of ILVerify tool in source build.

Testing

Fix verified locally: #64817 (comment)

Risk

Low

@ghostghost added the area-Infrastructure-coreclr Only use for closed issues label Feb 9, 2022
@ghost

ghost commented Feb 9, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #64833 to release/6.0

/cc @jkotas

Customer Impact

Testing

Risk

Author:github-actions[bot]
Assignees:-
Labels:

area-Infrastructure-coreclr

Milestone:-

@jkotasjkotas added the area-Tools-ILVerification Issues related to ilverify tool and IL verification in general label Feb 9, 2022
@ghost

ghost commented Feb 9, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #64833 to release/6.0

/cc @jkotas

Customer Impact

Build break in source build introduced by .NET SDK picking up a newer version of System.Command line library that conflicts with the version used by ILVerify tool. The fix is to disable building of ILVerify tool in source build.

Testing

Fix verified locally: #64817 (comment)

Risk

Low

Author:github-actions[bot]
Assignees:-
Labels:

area-Infrastructure-coreclr, area-ILVerification

Milestone:-

@jkotasjkotas removed the area-Infrastructure-coreclr Only use for closed issues label Feb 9, 2022

@jeffschwMSFTjeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. We should take for consideration in 6.0.x

@jkotas
jkotas requested a review from TIHanFebruary 9, 2022 17:50
@jeffschwMSFTjeffschwMSFT added the Servicing-consider Issue for next servicing release review label Feb 10, 2022
@leecowleecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Feb 10, 2022
@leecowleecow added this to the 6.0.3 milestone Feb 10, 2022
@jeffschwMSFT
jeffschwMSFT merged commit 4fde4c1 into release/6.0Feb 10, 2022
@akoeplinger
akoeplinger deleted the backport/pr-64833-to-release/6.0 branch February 12, 2022 00:21
@ghostghost locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Tools-ILVerificationIssues related to ilverify tool and IL verification in generalServicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@MichaelSimons@jeffschwMSFT@hoyosjs@leecow@jkotas