[tests] Add MonoApi runtime tests by lambdageek · Pull Request #65221 · dotnet/runtime

lambdageek · 2022-02-11T21:47:17Z

Contributes to #64456

Create a new directory src/tests/Interop/MonoAPI for tests that use the mono embedding API.

Move the mono libtest.c native library along with managed tests: InstallEHCallback.cs, PInvokeDetach.cs and Thunks.cs to src/tests/Interop/MonoAPI/...

The native library (now called mono-embedding-api-test.c) builds on all platforms where we build native support libraries for the runtime tests.

The managed tests only run on desktop mono configurations for now.

Fixed C++ compilation issues.

More ugly hacks.

Had to copy the w32_find_symbol code that searches for a symbol in every module.

Delete some unrunnable tests. Copy some basic eglib utilities into the test.

Maybe get the module name from managed, based on platform, instead?

Not expected to run on coreclr or mono on wasm or mobile, for now.

lambdageek · 2022-03-01T20:32:29Z

/cc @dotnet/interop-contrib @trylek I'd love some feedback on the overall setup for these tests

lambdageek · 2022-03-01T20:35:11Z

@lateralusX I kept most of the win32 code from libtest.c, and I believe the native library is building as part of the coreclr win32 tests build, but I haven't tried running the tests on Windows Mono.

AaronRobinsonMSFT · 2022-03-02T04:01:27Z

@@ -0,0 +1,6 @@
+// This file intentionally doesn't have header guards


Missing MIT banner.

AaronRobinsonMSFT · 2022-03-02T04:03:23Z

@@ -2,9 +2,11 @@
 using System.Reflection;


Missing MIT banner.

AaronRobinsonMSFT · 2022-03-02T04:03:41Z

@@ -7,14 +7,33 @@
 using System.Threading;


Missing MIT banner.

AaronRobinsonMSFT · 2022-03-02T04:03:58Z

@@ -2,19 +2,21 @@
 using System.Runtime.InteropServices;


Missing MIT banner.

AaronRobinsonMSFT · 2022-03-02T04:04:33Z

@@ -0,0 +1,32 @@
+using System;


Missing MIT banner.

AaronRobinsonMSFT · 2022-03-02T04:08:06Z

 add_subdirectory(ObjectiveC/ObjectiveCMarshalAPI)
 endif()
+
+add_subdirectory(MonoAPI/Native)


Let's move this up to before the first if branch since it should be always done and with that "group".

AaronRobinsonMSFT · 2022-03-02T04:08:24Z

@@ -0,0 +1,1088 @@
+


Missing MIT banner.

lateralusX · 2022-03-02T08:24:52Z

@lateralusX I kept most of the win32 code from libtest.c, and I believe the native library is building as part of the coreclr win32 tests build, but I haven't tried running the tests on Windows Mono.

OK, I can look at that once the PR has been merged.

lambdageek · 2022-03-02T22:23:21Z

Interesting, thunks test failure on llvmaot is relevant. need to check if that test ran with aot in mono/mono

lambdageek · 2022-03-03T15:17:20Z

Interesting, thunks test failure on llvmaot is relevant. need to check if that test ran with aot in mono/mono

Yea, we skipped that test on AOT configurations in mono/mono

In the mono/mono repo that test was not expected to work with AOT

ghost assigned lambdageek Feb 11, 2022

ghost added the area-Build-mono label Feb 11, 2022

lambdageek added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) and removed area-Build-mono labels Feb 11, 2022

lambdageek force-pushed the add-monoapi-runtime-tests branch 7 times, most recently from 00af384 to 7bbc8dbCompare February 16, 2022 16:26

lambdageek mentioned this pull request Feb 16, 2022
[MonoAPI] embedding API testing and API headers quality of life improvements #64456
Closed
3 tasks

lambdageek force-pushed the add-monoapi-runtime-tests branch 3 times, most recently from 2d5c50e to 9cb521dCompare February 24, 2022 03:55

runfoappBot mentioned this pull request Feb 24, 2022
system.diagnostics.tests.providermetadatatests.getprovidernames_assertproperties #64153
Open

lambdageekand others added 14 commits March 1, 2022 15:01

copy libtest.c from mono to src/tests and add cmake
9e5a43b

XXX HACK - find the runtime headers
529d3ef

builds, but doesn't link (needs eglib)
e521ae5
Fixed C++ compilation issues.

XXX link eglib into embedded API test shared lib
beb006e
More ugly hacks.

Make it build with the monoapi project
09c9d21

Adjust to src/native/monoapi path
3bd805b

test: remove mono-compiler.h dependency
baa02eb

Remove dependency on gmodule.h
a4a5c00
Had to copy the w32_find_symbol code that searches for a symbol in every module.

Remove test library eglib dependency
bdfc029
Delete some unrunnable tests. Copy some basic eglib utilities into the test.

Move native embedding API test lib to Interop/MonoAPI/Native
243d879

Move install_eh_callback test to src/tests/Interop/MonoAPI/MonoMono
c18a64f

HACK: dlopen("libcoreclr.dylib")
c2acead
Maybe get the module name from managed, based on platform, instead?

add issues.targets excludes for MonoAPI tests
7d298df
Not expected to run on coreclr or mono on wasm or mobile, for now.

Add PInvokeDetach MonoAPI test
a3afdc6

lambdageek added 2 commits March 1, 2022 15:01

Add Thunks.cs tests
a631c42

Use a common setup method to probe for symbols
4d063ea

lambdageek force-pushed the add-monoapi-runtime-tests branch from 18e46d4 to 4d063eaCompare March 1, 2022 20:01

lambdageek added 2 commits March 1, 2022 15:12

simplify the native test library
d2c30de

Make the PInvokeDetach native code sleep less
3cd562b

lambdageek marked this pull request as ready for review March 1, 2022 20:29

lambdageek requested a review from marek-safar as a code owner March 1, 2022 20:29

lambdageek added area-Interop-mono and removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) labels Mar 1, 2022

lambdageek requested a review from vargaz March 1, 2022 20:31

lambdageek changed the title ~~[DRAFT] Add MonoApi runtime tests~~[tests] Add MonoApi runtime testsMar 1, 2022

jkoritzinsky reviewed Mar 1, 2022
View reviewed changes

Comment threadsrc/tests/issues.targets Outdated

fix wasm and mobile comment
6669e05

vargaz approved these changes Mar 1, 2022
View reviewed changes

AaronRobinsonMSFT approved these changes Mar 2, 2022
View reviewed changes

lambdageek added 2 commits March 3, 2022 10:16

change cmake order
07c5ec5

add MIT banner
0736ff1

lambdageek force-pushed the add-monoapi-runtime-tests branch from a7439ac to e2a4933Compare March 3, 2022 15:16

This was referenced Mar 3, 2022
System.Runtime.Serialization.Xml.Tests failed #59926
Closed
profiler.elt work item test failures in slowpatheltenter #60018
Closed
System.IO.Tests work item failing with SIGKILL #65791
Closed

skip Thunks test on AOT
8e3aa5e
In the mono/mono repo that test was not expected to work with AOT

lambdageek force-pushed the add-monoapi-runtime-tests branch from e2a4933 to 8e3aa5eCompare March 4, 2022 01:25

lambdageek merged commit 483b8f2 into dotnet:mainMar 4, 2022

ghost locked as resolved and limited conversation to collaborators Apr 3, 2022

Navigation Menu

Uh oh!

[tests] Add MonoApi runtime tests - #65221

[tests] Add MonoApi runtime tests#65221
lambdageek merged 42 commits into
dotnet:mainfrom
lambdageek:add-monoapi-runtime-tests

lambdageek commented Feb 11, 2022•
edited
Loading

Uh oh!

lambdageek commented Mar 1, 2022•
edited
Loading

Uh oh!

lambdageek commented Mar 1, 2022

Uh oh!

Uh oh!

AaronRobinsonMSFTMar 2, 2022

Uh oh!

AaronRobinsonMSFTMar 2, 2022

Uh oh!

AaronRobinsonMSFTMar 2, 2022

Uh oh!

AaronRobinsonMSFTMar 2, 2022

Uh oh!

AaronRobinsonMSFTMar 2, 2022

Uh oh!

AaronRobinsonMSFTMar 2, 2022

Uh oh!

AaronRobinsonMSFTMar 2, 2022

Uh oh!

lateralusX commented Mar 2, 2022

Uh oh!

lambdageek commented Mar 2, 2022

Uh oh!

lambdageek commented Mar 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		@@ -0,0 +1,6 @@
		// This file intentionally doesn't have header guards

Uh oh!

Conversation

lambdageek commented Feb 11, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lambdageek commented Mar 1, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lambdageek commented Mar 1, 2022

Uh oh!

Uh oh!

AaronRobinsonMSFTMar 2, 2022

Choose a reason for hiding this comment

Uh oh!

AaronRobinsonMSFTMar 2, 2022

Choose a reason for hiding this comment

Uh oh!

AaronRobinsonMSFTMar 2, 2022

Choose a reason for hiding this comment

Uh oh!

AaronRobinsonMSFTMar 2, 2022

Choose a reason for hiding this comment

Uh oh!

AaronRobinsonMSFTMar 2, 2022

Choose a reason for hiding this comment

Uh oh!

AaronRobinsonMSFTMar 2, 2022

Choose a reason for hiding this comment

Uh oh!

AaronRobinsonMSFTMar 2, 2022

Choose a reason for hiding this comment

Uh oh!

lateralusX commented Mar 2, 2022

Uh oh!

lambdageek commented Mar 2, 2022

Uh oh!

lambdageek commented Mar 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lambdageek commented Feb 11, 2022•
edited
Loading

lambdageek commented Mar 1, 2022•
edited
Loading