Skip to content

Remove JsonConverter.RuntimeType - #65224

Merged
eiriktsarpalis merged 1 commit into
dotnet:mainfrom
eiriktsarpalis:jsonconverter-runtimetype
Feb 15, 2022
Merged

Remove JsonConverter.RuntimeType#65224
eiriktsarpalis merged 1 commit into
dotnet:mainfrom
eiriktsarpalis:jsonconverter-runtimetype

Conversation

@eiriktsarpalis

@eiriktsarpaliseiriktsarpalis commented Feb 11, 2022

Copy link
Copy Markdown
Member

Backports infrastructural changes introduced in the polymorphic serialization prototype branch. JsonConverter.RuntimeType is an implementation detail stemming from interface support in collection converters, that has leaked into the JsonTypeInfo model. Removing it makes the contract model cleaner and makes the metadata infrastructure compatible with polymorphic deserialization.

Related to #54420, #63747.

@eiriktsarpaliseiriktsarpalis added this to the 7.0.0 milestone Feb 11, 2022
@eiriktsarpaliseiriktsarpalis self-assigned this Feb 11, 2022
@ghost

ghost commented Feb 11, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-json
See info in area-owners.md if you want to be subscribed.

Issue Details

Backports infrastructural changes introduced in the polymorphic serialization prototype branch. JsonConverter.RuntimeType is an implementation detail stemming from interface support in collection converters, that has leaked into the JsonTypeInfo model. Removing it makes the contract model cleaner and makes the metadata infrastructure compatible with polymorphic deserialization.

Related to #54420, #63747.

Author:eiriktsarpalis
Assignees:eiriktsarpalis
Labels:

area-System.Text.Json

Milestone:7.0.0

krwq
krwq reviewed Feb 15, 2022
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfo.cs Outdated
krwq
krwq reviewed Feb 15, 2022
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverter.cs Outdated
@krwq

krwq commented Feb 15, 2022

Copy link
Copy Markdown
Member

overall looks good, I think you should remove unnecessary RequiresUnreferencedCode (RUC) from the code, treat rest of the comments as enahncements and no need to block on them

@eiriktsarpalis
Remove JsonConverter.RuntimeType
88cec71
Backports changes introduced in the polymorphic deserialization prototype. JsonConverter.RuntimeType is an implementation detail stemming from interface support in collection converters, that has leaked into the JsonTypeInfo model. Removing it makes the contract model cleaner and makes the infrastructure compatible with polymorphic deserialization.
@eiriktsarpalis
eiriktsarpalisforce-pushed the jsonconverter-runtimetype branch from f165444 to 88cec71CompareFebruary 15, 2022 13:52
@eiriktsarpalis
eiriktsarpalis merged commit 8356c8a into dotnet:mainFeb 15, 2022
@eiriktsarpalis
eiriktsarpalis deleted the jsonconverter-runtimetype branch February 15, 2022 18:20
@eiriktsarpaliseiriktsarpalis mentioned this pull request Feb 17, 2022
Merged
@ghostghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@krwqkrwqkrwq approved these changes
@stevehartersteveharterAwaiting requested review from steveharter
@layomialayomiaAwaiting requested review from layomia

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-System.Text.Json

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@eiriktsarpalis@krwq