Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] [mono] Fix r8->i conversion on amd64. - #65329
Merged
Conversation
github-actionsBot
requested review from
SamMonoRT, imhameed, lambdageek and vargaz
as code ownersFebruary 14, 2022 19:55
ghost
commented
Feb 14, 2022
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
lambdageek
commented
Feb 14, 2022
Member
The corresponding s390x fix for the same issue is #65328 |
akoeplinger
approved these changes
Feb 21, 2022
lewing
commented
Mar 10, 2022
Member
the wasm aot failure is #66366 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #64467 to release/6.0
/cc @lambdageek@vargaz
Customer Impact
Conversions from a float to a native integer type incorrectly treat the result as a 32-bit quantity on 64-bit platforms. This PR is for the x64 and arm64 platforms, a similar fix for the s390x is in #65328
Testing
CI
Risk
Low