Skip to content

[wasm] Disable aot tests failing due to OOM - #65413

Merged
radical merged 2 commits into
dotnet:mainfrom
radical:disable-aot-oom
Feb 17, 2022
Merged

[wasm] Disable aot tests failing due to OOM#65413
radical merged 2 commits into
dotnet:mainfrom
radical:disable-aot-oom

Conversation

@radical

@radicalradical commented Feb 16, 2022

Copy link
Copy Markdown
Member

Also, disable System.Collections.Immutable.Tests failing due to #65335

- dotnet#65356 - OOM while linking
`System.Text.Json.SourceGeneration.Roslyn3.11.Tests`
- dotnet#65411 - possible OOM when
compiling `System.Text.Json.SourceGeneration.Roslyn4.0.Tests.dll.bc` -> `.o`
`System.Text.Json.SourceGeneration.Roslyn4.0.Tests`
- dotnet#61524 - OOM while linking
`System.Text.Json.Tests`
@radicalradical added the arch-wasm WebAssembly architecture label Feb 16, 2022
@ghost

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
Author:radical
Assignees:-
Labels:

arch-wasm

Milestone:-

@ghost

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghostghost assigned radicalFeb 16, 2022
@radicalradical added the wasm-aot-test WebAssembly AOT Test label Feb 16, 2022
@radical

Copy link
Copy Markdown
MemberAuthor

Failures are unrelated:

.packages\microsoft.dotnet.helix.sdk\7.0.0-beta.22110.7\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(55,5): error : (NETCORE_ENGINEERING_TELEMETRY=Helix) RestApiException`1: The response contained an invalid status code 500 Internal Server Error
Body: {"Message":"An error occured.","ActivityId":"7e9a71e9c19adf449cfd660111d7c343"}
at Microsoft.DotNet.Helix.Client.Job.OnDetailsFailed(Request req, Response res) in /_/src/Microsoft.DotNet.Helix/Client/CSharp/generated-code/Job.cs:line 490
at Microsoft.DotNet.Helix.Client.Job.DetailsAsync(String job, CancellationToken cancellationToken) in /_/src/Microsoft.DotNet.Helix/Client/CSharp/generated-code/Job.cs:line 452
at Microsoft.DotNet.Helix.Sdk.WaitForHelixJobCompletion.WaitForHelixJobAsync(String jobName, String queueName, String helixJobCancellationToken, CancellationToken cancellationToken) in /_/src/Microsoft.DotNet.Helix/Sdk/WaitForHelixJobCompletion.cs:line 49
at Microsoft.DotNet.Helix.Sdk.WaitForHelixJobCompletion.ExecuteCore(CancellationToken cancellationToken) in /_/src/Microsoft.DotNet.Helix/Sdk/WaitForHelixJobCompletion.cs:line 31
at Microsoft.DotNet.Helix.Sdk.HelixTask.Execute() in /_/src/Microsoft.DotNet.Helix/Sdk/HelixTask.cs:line 58

@radical

Copy link
Copy Markdown
MemberAuthor

Unrelated linker tests are failing with:

/__w/1/s/.dotnet/sdk/6.0.100/MSBuild.dll /nologo -maxcpucount /m -verbosity:m /v:minimal /bl:/__w/1/s/artifacts/log/Release/ToolsetRestore.binlog /clp:Summary /clp:ErrorsOnly;NoSummary /nr:false /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=true /p:__ToolsetLocationOutputFile=/__w/1/s/artifacts/toolset/7.0.0-beta.22114.7.txt /t:__WriteToolsetLocation /warnaserror /__w/1/s/artifacts/toolset/restore.proj
/__w/1/s/artifacts/toolset/restore.proj : error : Unable to load the service index for source https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json.
/__w/1/s/artifacts/toolset/restore.proj : error : Unable to load the service index for source https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json.

@steveisok

Copy link
Copy Markdown
Member

/backport to release/6.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1954288145

@github-actions

Copy link
Copy Markdown
Contributor

@steveisok backporting to release/6.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: [wasm] Disable aot tests failing due to OOM
Using index info to reconstruct a base tree...
M	src/libraries/tests.proj
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/tests.proj
CONFLICT (content): Merge conflict in src/libraries/tests.proj
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 [wasm] Disable aot tests failing due to OOM
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

steveisok pushed a commit to steveisok/runtime that referenced this pull request Mar 8, 2022
…configuration
Partial backport of dotnet#65413dotnet#61524 - OOM while linking `System.Text.Json.Tests`
carlossanlop pushed a commit that referenced this pull request Mar 10, 2022
…configuration (#66366)
Partial backport of #65413#61524 - OOM while linking `System.Text.Json.Tests`
Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
@ghostghost locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturewasm-aot-testWebAssembly AOT Test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@radical@steveisok@akoeplinger