Uh oh!
There was an error while loading. Please reload this page.
[Mono] Enable generating SIMD intrinsics for System.Numerics.Vector on Arm64 - #65486
Merged
Conversation
fanyang-mono
marked this pull request as ready for review
February 22, 2022 17:57
fanyang-mono
requested review from
SamMonoRT, imhameed, lambdageek and vargaz
as code ownersFebruary 22, 2022 17:57
vargaz
reviewed
Feb 22, 2022
Uh oh!
There was an error while loading. Please reload this page.
vargaz
reviewed
Feb 22, 2022
Uh oh!
There was an error while loading. Please reload this page.
vargaz
approved these changes
Feb 22, 2022
fanyang-mono
commented
Feb 24, 2022
MemberAuthor
@vargaz I pushed more change after your approval. Please review again. Thanks! |
vargaz
reviewed
Feb 25, 2022
Uh oh!
There was an error while loading. Please reload this page.
vargaz
reviewed
Feb 25, 2022
Uh oh!
There was an error while loading. Please reload this page.
vargaz
reviewed
Feb 25, 2022
Uh oh!
There was an error while loading. Please reload this page.
vargaz
approved these changes
Feb 25, 2022
vargaz
reviewed
Feb 26, 2022
Uh oh!
There was an error while loading. Please reload this page.
fanyang-mono
commented
Mar 7, 2022
MemberAuthor
@vargaz Could you please review one more time? I decided to check only the type for one argument instead of all vector arguments and return. Because I did some testing and found that the c# wouldn't allow arguments with different types. |
vargaz
approved these changes
Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribute to #64072
With this PR, methods of
System.Numerics.Vectorsupported inemit_sri_vectorwill be intrinsified on Arm64.Fixed#65318
Added/refactored vector element type check for all the cases in
emit_sri_vector.