Skip to content

[release/6.0] [mono] Fix stacktrace from DIM - #65509

Merged
ericstj merged 2 commits into
dotnet:release/6.0from
thaystg:thays_backport_60770_64566
Mar 10, 2022
Merged

[release/6.0] [mono] Fix stacktrace from DIM#65509
ericstj merged 2 commits into
dotnet:release/6.0from
thaystg:thays_backport_60770_64566

Conversation

@thaystg

@thaystgthaystg commented Feb 17, 2022

Copy link
Copy Markdown
Member

Backport of #60770 and #64566 to release/6.0
Fix an assertion when trying to get the callstack from a DIM.

Customer Impact

When trying to get the callstack from a DIM was hitting an assert and stopping the process.

Testing

Automatic tests added

Risk

Low Risk.

@ghostghost added the area-VM-meta-mono label Feb 17, 2022
@ghostghost assigned thaystgFeb 17, 2022
@teo-tsirpanisteo-tsirpanis added the Servicing-consider Issue for next servicing release review label Feb 17, 2022
@teo-tsirpanisteo-tsirpanis added this to the 6.0.x milestone Feb 17, 2022
@teo-tsirpanis

teo-tsirpanis commented Feb 17, 2022

Copy link
Copy Markdown
Contributor

Pardon me if I'm wrong but my understanding is that servicing PRs need to be tagged with Servicing-Consider and put on the appropriate release milestone. If that's OK I will keep that in mind for future servicing PRs I encounter.

c.c. @eiriktsarpalis

@runfoapprunfoappBot mentioned this pull request Feb 17, 2022
Closed
@eiriktsarpalis

eiriktsarpalis commented Feb 17, 2022

Copy link
Copy Markdown
Member

@teo-tsirpanisServicing-Consider is meant to mark a PR for director-level review, so I'd leave it up to the PR authors to apply the label themselves when they feel it's ready. I think it should be fine to leave it here though, thanks!

ilonatommy
ilonatommy reviewed Feb 18, 2022
View reviewed changes
Comment threadsrc/tests/Loader/classloader/DefaultInterfaceMethods/regressions/github60486.cs
StringSplitOptions.None
);

//Console.WriteLine(testStack);

@ilonatommyilonatommyFeb 18, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgotten commented out value check :)

@rbhandarbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Feb 22, 2022
@rbhandarbhanda modified the milestones: 6.0.x, 6.0.4Feb 22, 2022
@lewing

lewing commented Mar 10, 2022

Copy link
Copy Markdown
Member

aot failure is #66366

@ericstj
ericstj merged commit 518c76f into dotnet:release/6.0Mar 10, 2022
@ghostghost locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ilonatommyilonatommyilonatommy left review comments
@lewinglewinglewing approved these changes
@lambdageeklambdageeklambdageek approved these changes
@vargazvargazAwaiting requested review from vargaz
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@imhameedimhameedAwaiting requested review from imhameed

Assignees

@thaystgthaystg

Labels

area-VM-meta-monoServicing-approvedApproved for servicing release

Projects

None yet

Milestone

6.0.4

Development

Successfully merging this pull request may close these issues.

8 participants

@thaystg@teo-tsirpanis@eiriktsarpalis@lewing@lambdageek@ilonatommy@ericstj@rbhanda