Uh oh!
There was an error while loading. Please reload this page.
Fix an incorrect assert - #65564
Merged
jakobbotsch merged 1 commit intoFeb 18, 2022
Merged
Conversation
ghost
commented
Feb 18, 2022
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsWe only require "greater than" on x86. No test added because the code was (and is) correct for the non-x86 case, just the assert condition was faulty.
|
We only require the "greater than" condition on x86.
SingleAccretionforce-pushed
the
Push-8-Byte-Args-Fix-Assert
branch
from
February 18, 2022 15:12
bfd57fc to
52fc182Comparejakobbotsch
approved these changes
Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only require "greater than" on x86. Ref.
No test added because the code was (and is) correct for the non-x86 case, just the assert condition was faulty.
Fixes#64805 (comment).