Uh oh!
There was an error while loading. Please reload this page.
Cleanup fp registers assignments from arm64 path - #65629
Merged
Merged
Conversation
am11force-pushed
the
feature/cleanups/pal
branch
from
February 20, 2022 12:00
05f964e to
6a15696Compaream11
commented
Mar 30, 2022
MemberAuthor
@janvorli, could you please take a look? |
janvorli
commented
Mar 30, 2022
Member
Oh, I am sorry, I've completely missed this somehow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This path does not compile (dead code), and it has a bug:
ASSIGN_FP_REGrequires two arguments while one is passed at call sites.Ref:#63596 (comment)