Skip to content

Fix NTAuthentication.MakeSignature/VerifySignature on Linux - #65679

Merged
wfurt merged 3 commits into
dotnet:mainfrom
filipnavara:ntlm_test_2
May 12, 2022
Merged

Fix NTAuthentication.MakeSignature/VerifySignature on Linux#65679
wfurt merged 3 commits into
dotnet:mainfrom
filipnavara:ntlm_test_2

Conversation

@filipnavara

@filipnavarafilipnavara commented Feb 21, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Contributes to #65678

@ghostghost added community-contribution Indicates that the PR has been added by a community member area-System.Net.Security labels Feb 21, 2022
@ghost

ghost commented Feb 21, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Build on top of #65611, contributes to #65678

Author:filipnavara
Assignees:-
Labels:

area-System.Net.Security, community-contribution

Milestone:-

@filipnavarafilipnavara changed the title Fix NTAuthentication.MakeSignature on LinuxFix NTAuthentication.MakeSignature/VerifySignature on Linux and macOSFeb 22, 2022
@filipnavara

This comment was marked as outdated.

Sign in to view
@filipnavarafilipnavara changed the title Fix NTAuthentication.MakeSignature/VerifySignature on Linux and macOSFix NTAuthentication.MakeSignature/VerifySignature on LinuxFeb 22, 2022
@ghostghost closed this Mar 25, 2022
@ghost

ghost commented Mar 25, 2022

Copy link
Copy Markdown

Draft Pull Request was automatically closed for inactivity. Please let us know if you'd like to reopen it.

wfurt
wfurt reviewed Mar 25, 2022
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/Security/NegotiateStreamPal.Unix.cs Outdated
@ghost

ghost commented Apr 15, 2022

Copy link
Copy Markdown

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@ghost

ghost commented Apr 30, 2022

Copy link
Copy Markdown

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

@ghostghost closed this Apr 30, 2022
@filipnavarafilipnavara reopened this May 7, 2022
@ghostghost removed the no-recent-activity label May 7, 2022
@filipnavara
filipnavara requested a review from wfurtMay 7, 2022 07:03
filipnavara
filipnavara commented May 7, 2022
View reviewed changes
Comment threadsrc/libraries/System.Net.Security/tests/UnitTests/NTAuthenticationTests.cs Outdated
@filipnavara
filipnavara marked this pull request as ready for review May 7, 2022 07:19
wfurt
wfurt approved these changes May 12, 2022
View reviewed changes

@wfurtwfurt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt

wfurt commented May 12, 2022

Copy link
Copy Markdown
Member

System.IO.Pipes.Tests failure is unrelated.

@wfurt
wfurt merged commit 7b5f40f into dotnet:mainMay 12, 2022
@rzikmrzikm mentioned this pull request May 13, 2022
Closed
@ghostghost locked as resolved and limited conversation to collaborators Jun 11, 2022
@karelzkarelz added this to the 7.0.0 milestone Jul 19, 2022
@filipnavara
filipnavara deleted the ntlm_test_2 branch June 5, 2025 07:45
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wfurtwfurtwfurt approved these changes
+1 more reviewer
@am11am11am11 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Net.Securitycommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@filipnavara@wfurt@am11@karelz