Skip to content

Cleanup fragile NGen leftovers - #65869

Merged
jkotas merged 3 commits into
dotnet:mainfrom
jkotas:cleanup
Feb 25, 2022
Merged

Cleanup fragile NGen leftovers#65869
jkotas merged 3 commits into
dotnet:mainfrom
jkotas:cleanup

Conversation

@jkotas

Copy link
Copy Markdown
Member

No description provided.

@jkotas

Copy link
Copy Markdown
MemberAuthor

Follow up from loongarch code review

@BruceForstallBruceForstall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadsrc/coreclr/vm/i386/asmhelpers.S
Comment threadsrc/coreclr/vm/arm/asmhelpers.S Outdated
@jkotas
jkotas merged commit 30f30a3 into dotnet:mainFeb 25, 2022
@jkotas
jkotas deleted the cleanup branch February 25, 2022 05:57
@ViktorHofer

Copy link
Copy Markdown
Member

Do we still use NGen for code optimization? Asking as the target in

<TargetName="SetApplyNgenOptimization"
runs.

@jkotas

Copy link
Copy Markdown
MemberAuthor

We do use PGO data for optimizations, but this specific path is probably not used anymore. @davidwrighton will know for sure.

@ghostghost locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jkotas@ViktorHofer@am11@BruceForstall