Skip to content

Run superpmi-replay pipeline on JIT PRs - #66063

Merged
BruceForstall merged 1 commit into
dotnet:mainfrom
BruceForstall:SpmiReplayOnJitPullRequest
Mar 10, 2022
Merged

Run superpmi-replay pipeline on JIT PRs#66063
BruceForstall merged 1 commit into
dotnet:mainfrom
BruceForstall:SpmiReplayOnJitPullRequest

Conversation

@BruceForstall

@BruceForstallBruceForstall commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

Currently, the runtime-coreclr superpmi-replay pipeline is run
when a JIT change is merged. This change moves the checking to happen
on the PR pre-merge, as a requirement for merging.

@BruceForstall
Run superpmi-replay pipeline on JIT PRs
316a2fe
Currently, the `runtime-coreclr superpmi-replay` pipeline is run
when a JIT change is merged. This change moves the checking to happen
on the PR pre-merge, as a requirement for merging.
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 2, 2022
@ghost

ghost commented Mar 2, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Currently, the runtime-coreclr superpmi-replay pipeline is run
when a JIT change is merged. This change moves the checking to happen
on the PR pre-merge, as a requirement for merging.

Author:BruceForstall
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@BruceForstall

BruceForstall commented Mar 2, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Currently, the superpmi-replay pipeline takes 3 hours. Seems like we should increase the Helix parallelism to reduce this time if we're going to run the pre-merge.

@BruceForstall

BruceForstall commented Mar 2, 2022

Copy link
Copy Markdown
ContributorAuthor

@dotnet/jit-contrib

@kunalspathak

kunalspathak commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

Currently, the superpmi-replay pipeline takes 3 hours. Seems like we should increase the Helix parallelism to reduce this time if we're going to run the pre-merge.

Are you planning to change this before merging this PR?

@kunalspathak

kunalspathak commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

Currently, the superpmi-replay pipeline takes 3 hours. Seems like we should increase the Helix parallelism to reduce this time if we're going to run the pre-merge.

Are you planning to change this before merging this PR?

Never mind. Didn't see #66065

@BruceForstall

BruceForstall commented Mar 2, 2022

Copy link
Copy Markdown
ContributorAuthor

@dotnet/jit-contrib Now that #66065, this is ready to go, as long as we're willing to accept 1h40m time for a PR job. (I'm not sure how long our existing jobs take...)

@kunalspathak

kunalspathak commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

I don't mind having this gate for JIT changes.

@BruceForstall

BruceForstall commented Mar 9, 2022

Copy link
Copy Markdown
ContributorAuthor

@dotnet/jit-contrib Any more opinions on this, and/or PR approval?

kunalspathak
kunalspathak approved these changes Mar 9, 2022
View reviewed changes

@kunalspathakkunalspathak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was already merged and wondered couple of times why it didn't get triggered on my PRs. Now I know why. :)

@BruceForstall
BruceForstall merged commit f1c298f into dotnet:mainMar 10, 2022
@BruceForstall
BruceForstall deleted the SpmiReplayOnJitPullRequest branch March 10, 2022 01:01
@ghostghost locked as resolved and limited conversation to collaborators Apr 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@BruceForstallBruceForstall

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BruceForstall@kunalspathak