Skip to content

Don't add TestLibrary as a reference to all runtime tests - #66157

Merged
trylek merged 1 commit into
dotnet:mainfrom
trylek:ExplicitTestLibrary
Mar 4, 2022
Merged

Don't add TestLibrary as a reference to all runtime tests#66157
trylek merged 1 commit into
dotnet:mainfrom
trylek:ExplicitTestLibrary

Conversation

@trylek

@trylektrylek commented Mar 3, 2022

Copy link
Copy Markdown
Member

When I was tagging several architecture-dependent runtime tests
with the ConditionalFact attribute, I added CoreCLRTestLibrary
as a general reference. This started causing timeouts in Mono AOT
tests because the library needs to be compiled many times.
As there's only a small number of architecture-dependent tests,
I have modified the change so that the test library is only added
explicitly to architecture-dependent tests.

Fixes: #66083

Thanks

Tomas

/cc @dotnet/runtime-infrastructure

@trylek
Don't add TestLibrary as a reference to all runtime tests
7deb181
When I was tagging several architecture-dependent runtime tests
with the ConditionalFact attribute, I added CoreCLRTestLibrary
as a general reference. This started causing timeouts in Mono AOT
tests because the library needs to be compiled many times.
As there's only a small number of architecture-dependent tests,
I have modified the change so that the test library is only added
explicitly to architecture-dependent tests.
Fixes: dotnet#66083
Thanks
Tomas
@ghostghost assigned trylekMar 3, 2022
@ghost

ghost commented Mar 3, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

When I was tagging several architecture-dependent runtime tests
with the ConditionalFact attribute, I added CoreCLRTestLibrary
as a general reference. This started causing timeouts in Mono AOT
tests because the library needs to be compiled many times.
As there's only a small number of architecture-dependent tests,
I have modified the change so that the test library is only added
explicitly to architecture-dependent tests.

Fixes: #66083

Thanks

Tomas

/cc @dotnet/runtime-infrastructure

Author:trylek
Assignees:-
Labels:

area-Infrastructure-mono

Milestone:-

@trylek

trylek commented Mar 3, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Mar 3, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

fanyang-mono
fanyang-mono approved these changes Mar 3, 2022
View reviewed changes

@fanyang-monofanyang-mono left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change!

@trylek
trylek merged commit aaa2388 into dotnet:mainMar 4, 2022
@trylek
trylek deleted the ExplicitTestLibrary branch March 4, 2022 10:50
@SamMonoRTSamMonoRT mentioned this pull request Mar 7, 2022
Closed
@ghostghost locked as resolved and limited conversation to collaborators Apr 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@SamMonoRTSamMonoRTSamMonoRT approved these changes
@fanyang-monofanyang-monofanyang-mono approved these changes

Assignees

@trylektrylek

Labels

area-Infrastructure-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TIME OUT - Mono llvmfullaot Pri0 Runtime Tests Run Linux arm64 release

4 participants

@trylek@jkoritzinsky@SamMonoRT@fanyang-mono