Skip to content

Partial revert of Maui Install Fix #65904 - #66221

Merged
LoopedBard3 merged 4 commits into
dotnet:mainfrom
LoopedBard3:RevertMauiRollbackFix
Mar 8, 2022
Merged

Partial revert of Maui Install Fix #65904#66221
LoopedBard3 merged 4 commits into
dotnet:mainfrom
LoopedBard3:RevertMauiRollbackFix

Conversation

@LoopedBard3

Copy link
Copy Markdown
Member

Partially reverts the Maui Install Mitigation put in place as part of #65904. This is possible because the Maui team added the emscription line back into the main.json rollback file so we no longer need to add it ourselves. I kept the Nuget.config file download and usage because there are 2 Darc package sources that were added as install sources and using the Nuget.config instead will keep us automatically up to date as the package sources update.

@LoopedBard3LoopedBard3 self-assigned this Mar 4, 2022
@ghostghost added the area-Infrastructure-coreclr Only use for closed issues label Mar 4, 2022
@ghost

ghost commented Mar 4, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Partially reverts the Maui Install Mitigation put in place as part of #65904. This is possible because the Maui team added the emscription line back into the main.json rollback file so we no longer need to add it ourselves. I kept the Nuget.config file download and usage because there are 2 Darc package sources that were added as install sources and using the Nuget.config instead will keep us automatically up to date as the package sources update.

Author:LoopedBard3
Assignees:LoopedBard3
Labels:

area-Infrastructure-coreclr

Milestone:-

@LoopedBard3

Copy link
Copy Markdown
MemberAuthor

Verified that the Install Maui Workload still succeeds and grabs the correct stuff in a test pipeline run.

@LoopedBard3
LoopedBard3 merged commit 220e677 into dotnet:mainMar 8, 2022
@LoopedBard3
LoopedBard3 deleted the RevertMauiRollbackFix branch March 8, 2022 23:57
@ghostghost locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@LoopedBard3@DrewScoggins