Uh oh!
There was an error while loading. Please reload this page.
Fix a couple issues with GTF_GLOB_REF setting - #66247
Merged
Merged
Conversation
Add it to INDs and BLKs off of exposed ADDRs in addition to OBJs. Remove code from args morphing which was re-deriving the side effects flags for an OBJ argument, it was: a) Unnecessary, as morph has already done all the work. b) Incorrect, as it lost GTF_GLOB_REF for OBJ(ADDR(LCL (AX)))-like trees.
ghost
commented
Mar 5, 2022
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsAdd it to Remove code from args morphing which was re-deriving the side effects flags for an a) Unnecessary, as morph has already done all the work. Surgically fixes some asserts seen during No diffs are expected.
|
SingleAccretionforce-pushed
the
Fix-Some-Flags-Issues
branch
from
March 5, 2022 18:51
fc2b007 to
189b03cCompareSingleAccretion
commented
Mar 5, 2022
ContributorAuthor
@dotnet/jit-contrib |
SingleAccretion
marked this pull request as ready for review
March 5, 2022 20:21
jakobbotsch
approved these changes
Mar 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add it to
INDs andBLKs off of exposedADDRs in addition toOBJs.Remove code from args morphing which was re-deriving the side effects flags for an
OBJargument, it was:a) Unnecessary, as morph has already done all the work.
b) Incorrect, as it lost
GTF_GLOB_REFforOBJ(ADDR(LCL (AX)))-like trees.Surgically fixes some asserts seen during
TYP_STRUCTLCL_FLDwork.No diffs.