Skip to content

[release/6.0][wasm][debugger] Fix incompatibility between runtime and nuget package - #66301

Merged
ericstj merged 1 commit into
dotnet:release/6.0from
thaystg:thays_backport_66295
Mar 10, 2022
Merged

[release/6.0][wasm][debugger] Fix incompatibility between runtime and nuget package#66301
ericstj merged 1 commit into
dotnet:release/6.0from
thaystg:thays_backport_66295

Conversation

@thaystg

@thaystgthaystg commented Mar 7, 2022

Copy link
Copy Markdown
Member

Customer Impact

When the customer created a project using release 6.0.0 and then install new versions of VS like: 6.0.2, the nuget package of the wasm project is not updated automatically, so the user uses the runtime 6.0.2 and the nuget package 6.0.0, the BrowserDebugProxy is inside this nuget package and one of our changes to show multidimensional array, caused this incompatibility.

Related Issues

https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1470864
https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1484798

Testing

Manual testing

Risk

Very Low. This is just keeping the old behavior if the runtime is updated and the BrowserDebugProxy is not, so the multidimensional array will not work, but simple arrays will continue working.

@thaystgthaystg added the Servicing-consider Issue for next servicing release review label Mar 7, 2022
@thaystg
thaystg requested a review from lewingMarch 7, 2022 17:13
@ghostghost assigned thaystgMar 7, 2022
@ghostghost added the area-Debugger-mono label Mar 7, 2022
@ghost

ghost commented Mar 7, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Customer Impact

When the customer created a project using release 6.0.0 and then install new versions of VS like: 6.0.2, the nuget package of the wasm project is not updated automatically, so the user uses the runtime 6.0.2 and the nuget package 6.0.0, the BrowserDebugProxy is inside this nuget package and one of our changes to show multidimensional array, caused this incompatibility.

Testing

Manual testing

Risk

Very Low. This is just keeping the old behavior if the runtime is updated and the BrowserDebugProxy is not, so the multidimensional array will not work, but simple arrays will continue working.

Author:thaystg
Assignees:thaystg
Labels:

Servicing-consider, area-Debugger-mono

Milestone:-

@lewinglewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Mar 10, 2022
@lewing

Copy link
Copy Markdown
Member

approved in email

@lewing

Copy link
Copy Markdown
Member

wasm AOT failure is #66366

@lambdageeklambdageek added this to the 6.0.x milestone Mar 10, 2022
@ericstjericstj modified the milestones: 6.0.x, 6.0.4Mar 10, 2022
@ericstj

Copy link
Copy Markdown
Member

@lewing what about the Mono Android x64 Release failures? Are those known?

@akoeplinger

Copy link
Copy Markdown
Member

@ericstj yes those are infrastructure issues (the test app failed to install on the device), tracked by #65840

@ericstj
ericstj merged commit 4afa671 into dotnet:release/6.0Mar 10, 2022
@ghostghost locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Debugger-monoServicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@thaystg@lewing@ericstj@akoeplinger@lambdageek