Uh oh!
There was an error while loading. Please reload this page.
Rename GeneratedDllImportAttribute -> LibraryImportAttribute - #66307
Merged
Conversation
ghost
commented
Mar 7, 2022
Tagging subscribers to this area: @dotnet/interop-contrib Issue Detailsnull
|
AraHaan
reviewed
Mar 7, 2022
Uh oh!
There was an error while loading. Please reload this page.
elinor-fungforce-pushed
the
renameAttribute
branch
from
March 8, 2022 18:22
638e202 to
2d90838Compareelinor-fungforce-pushed
the
renameAttribute
branch
from
March 8, 2022 22:56
2d90838 to
d2eb353Compareelinor-fung
marked this pull request as ready for review
March 9, 2022 02:58
elinor-fung
commented
Mar 9, 2022
MemberAuthor
Failures are unrelated. |
AaronRobinsonMSFT
approved these changes
Mar 9, 2022
Uh oh!
There was an error while loading. Please reload this page.
…rtGenerator.UnitTests/CodeSnippets.cs Co-authored-by: Aaron Robinson <arobins@microsoft.com>
elinor-fung
commented
Mar 10, 2022
MemberAuthor
Merging - last commit was comment-only. |
deeprobin added a commit
to deeprobin/runtime
that referenced
this pull request
Mar 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
GeneratedDllImportAttribute->LibraryImportAttribute.After this,
LibraryImportAttributeshould match the approved API. And then we can actually add/expose it in libraries.Contributes to #46822