Skip to content

Check gtClassProfileCandidateInfo before instrumentation - #66388

Merged
EgorBo merged 2 commits into
dotnet:mainfrom
EgorBo:fix-gdv-cast
Mar 10, 2022
Merged

Check gtClassProfileCandidateInfo before instrumentation#66388
EgorBo merged 2 commits into
dotnet:mainfrom
EgorBo:fix-gdv-cast

Conversation

@EgorBo

Copy link
Copy Markdown
Member

BBF_HAS_CLASS_PROFILE doesn't mean all virtual and cast calls in the current block are instrumentable.

It fixes the crash I observed in dotnet-trace

@ghostghost assigned EgorBoMar 9, 2022
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 9, 2022
@ghost

ghost commented Mar 9, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

BBF_HAS_CLASS_PROFILE doesn't mean all virtual and cast calls in the current block are instrumentable.

It fixes the crash I observed in dotnet-trace

Author:EgorBo
Assignees:EgorBo
Labels:

area-CodeGen-coreclr

Milestone:-

@EgorBo

Copy link
Copy Markdown
MemberAuthor

cc @AndyAyersMS@jakobbotsch

Comment threadsrc/coreclr/jit/fgprofile.cpp Outdated
@EgorBo
EgorBo merged commit cdb1d26 into dotnet:mainMar 10, 2022
@ghostghost locked as resolved and limited conversation to collaborators Apr 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@EgorBo@jakobbotsch@AndyAyersMS