Skip to content

Implement System.Decimal.Scale - #66403

Merged
danmoseley merged 1 commit into
dotnet:mainfrom
MichalPetryka:decimal-scale
Mar 10, 2022
Merged

Implement System.Decimal.Scale#66403
danmoseley merged 1 commit into
dotnet:mainfrom
MichalPetryka:decimal-scale

Conversation

@MichalPetryka

Copy link
Copy Markdown
Contributor

Adds System.Decimal.Scale, a property that
returns the scaling factor of the decimal.

Closes#65074.

@ghostghost added the community-contribution Indicates that the PR has been added by a community member label Mar 9, 2022
@ghost

ghost commented Mar 9, 2022

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented Mar 9, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost

ghost commented Mar 9, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Adds System.Decimal.Scale, a property that
returns the scaling factor of the decimal.

Closes #65074.

Author:MichalPetryka
Assignees:-
Labels:

area-System.Runtime, new-api-needs-documentation, community-contribution

Milestone:-

@deeprobindeeprobin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Adds System.Decimal.Scale, a property that
returns the scaling factor of the decimal.
Closesdotnet#65074.
@danmoseley
danmoseley merged commit 4ba076e into dotnet:mainMar 10, 2022
@danmoseley

Copy link
Copy Markdown
Contributor

Thanks for the contribution @MichalPetryka . BTW as a small nit, it is ideal to not do a force push after the review, as everything must be re-reviewed rather than just any new changes since the review. Of course in this change that is easy for us.

@ghostghost locked as resolved and limited conversation to collaborators Apr 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Runtimecommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Scale property for the decimal datatype

4 participants

@MichalPetryka@danmoseley@deeprobin@tannergooding