Skip to content

Expose LibraryImportAttribute - #66434

Merged
elinor-fung merged 7 commits into
dotnet:mainfrom
elinor-fung:exposeLibraryImportAttribute
Mar 16, 2022
Merged

Expose LibraryImportAttribute#66434
elinor-fung merged 7 commits into
dotnet:mainfrom
elinor-fung:exposeLibraryImportAttribute

Conversation

@elinor-fung

@elinor-fungelinor-fung commented Mar 10, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Expose LibraryImportAttribute in runtime libraries.

Resolves#46822

@elinor-fungelinor-fung added this to the 7.0.0 milestone Mar 10, 2022
@ghost

ghost commented Mar 10, 2022

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented Mar 10, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:elinor-fung
Assignees:-
Labels:

area-System.Runtime.InteropServices

Milestone:7.0.0

jkotas
jkotas reviewed Mar 10, 2022
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Runtime/InteropServices/LibraryImportAttribute.cs Outdated
jkotas
jkotas reviewed Mar 10, 2022
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems Outdated
jkotas
jkotas reviewed Mar 10, 2022
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/ref/System.Text.Json.csproj Outdated
jkotas
jkotas reviewed Mar 10, 2022
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/src/System.Text.Json.csproj Outdated
jkotas
jkotas reviewed Mar 10, 2022
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/tests/System.Text.Json.Tests/System.Text.Json.Tests.csproj Outdated
stephentoub
stephentoub reviewed Mar 10, 2022
View reviewed changes
Comment threadeng/generators.targets
stephentoub
stephentoub reviewed Mar 10, 2022
View reviewed changes
Comment threadsrc/libraries/System.Runtime.InteropServices/ref/System.Runtime.InteropServices.cs Outdated
@runfoapprunfoappBot mentioned this pull request Mar 10, 2022
Closed
@AaronRobinsonMSFT

AaronRobinsonMSFT commented Mar 10, 2022

Copy link
Copy Markdown
Member

@layomia FYI for JSON source gen changes

elinor-fungand others added 2 commits March 10, 2022 09:06
@elinor-fung@jkotas@stephentoub
Apply suggestions from code review
76898f8
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
@elinor-fung
Apply suggestions from code review
9b8a553
@elinor-fung
elinor-fung marked this pull request as ready for review March 11, 2022 02:05
@elinor-fung

elinor-fung commented Mar 11, 2022

Copy link
Copy Markdown
MemberAuthor

Failures in System.Text.Json.Tests are:

AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Mar 14, 2022
View reviewed changes
Comment thread...ibraries/System.Private.CoreLib/src/System/Runtime/InteropServices/LibraryImportAttribute.cs Outdated
Comment thread...ibraries/System.Private.CoreLib/src/System/Runtime/InteropServices/LibraryImportAttribute.cs Outdated
Comment thread...ibraries/System.Private.CoreLib/src/System/Runtime/InteropServices/LibraryImportAttribute.cs Outdated
Comment thread...ibraries/System.Private.CoreLib/src/System/Runtime/InteropServices/LibraryImportAttribute.cs
@elinor-fung@AaronRobinsonMSFT
Apply suggestions from code review
323a161
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
deeprobin
deeprobin approved these changes Mar 15, 2022
View reviewed changes

@deeprobindeeprobin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks in general good to me.

Are there some tests validating the Attribute properties?

Comment thread...ibraries/System.Private.CoreLib/src/System/Runtime/InteropServices/LibraryImportAttribute.cs
@elinor-fung
elinor-fung merged commit d268888 into dotnet:mainMar 16, 2022
@elinor-fung
elinor-fung deleted the exposeLibraryImportAttribute branch March 16, 2022 03:05
@teo-tsirpanisteo-tsirpanis mentioned this pull request Mar 17, 2022
Merged
@runfoapprunfoappBot mentioned this pull request Mar 18, 2022
Closed
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
@elinor-fung@radekdoulik
ExposeLibraryImportAttribute(dotnet#66434)
6f106d1
@ghostghost locked as resolved and limited conversation to collaborators Apr 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub left review comments
@jkotasjkotasjkotas left review comments
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
+1 more reviewer
@deeprobindeeprobindeeprobin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@elinor-fungelinor-fung

Labels

area-System.Runtime.InteropServicesnew-api-needs-documentation

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

LibraryImportAttribute for p/invoke source generation

6 participants

@elinor-fung@AaronRobinsonMSFT@jkoritzinsky@stephentoub@jkotas@deeprobin