Remove dotnet6 feeds by ViktorHofer · Pull Request #66447 · dotnet/runtime

ViktorHofer · 2022-03-10T09:58:59Z

The current main branch's corresponding feeds are the dotnet7 ones and the dotnet6 ones shouldn't be used.
Please see my comments below for packages that were missing.

dotnet7 feeds are currently the target feeds for the main branch. The dotnet6 feeds shouldn't be used anymore.

ghost · 2022-03-10T09:59:06Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

dotnet7 feeds are currently the target feeds for the main branch. The dotnet6 feeds shouldn't be used anymore.

Author:	ViktorHofer
Assignees:	ViktorHofer
Labels:	`area-Infrastructure`
Milestone:	-

ViktorHofer · 2022-03-10T11:02:43Z

@dotnet/ncl the msquic transport package pushes into the dotnet7-transport feed but dotnet/runtime gets the version from the dotnet6-transport feed. I'm fixing the package version in dotnet/msquic#71 and am also updating the darc subscription so that it fetches the package from the dotnet7-transport feed instead.

ViktorHofer · 2022-03-15T09:07:14Z

I manually pushed the latest dotnet/optimization packages to the dotnet7-transport feed as the dotnet/optimization builds are currently broken.

ViktorHofer · 2022-03-15T09:07:31Z

/azp run dotnet-linker-tests

ViktorHofer · 2022-03-15T09:07:38Z

/azp run runtime

azure-pipelines · 2022-03-15T09:07:41Z

Azure Pipelines successfully started running 1 pipeline(s).

ViktorHofer · 2022-03-15T09:07:58Z

/azp run runtime-dev-innerloop

azure-pipelines · 2022-03-15T09:08:03Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2022-03-15T09:08:07Z

Azure Pipelines successfully started running 1 pipeline(s).

ViktorHofer · 2022-03-15T09:08:09Z

/azp run runtime-staging

azure-pipelines · 2022-03-15T09:08:17Z

Azure Pipelines successfully started running 1 pipeline(s).

agocke

LGTM, thanks!

ViktorHofer · 2022-03-16T10:27:26Z

ld : error : object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(nethost.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13) [/Users/runner/work/1/s/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj]
##[error]ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(nethost.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13)
ld : error : object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(nethost.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13) [/Users/runner/work/1/s/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj]
##[error]ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(nethost.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13)
ld : error : object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(utils.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13) [/Users/runner/work/1/s/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj]
##[error]ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(utils.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13)
ld : error : object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(utils.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13) [/Users/runner/work/1/s/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj]
##[error]ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(utils.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13)
ld : error : object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(fxr_resolver.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13) [/Users/runner/work/1/s/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj]
##[error]ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(fxr_resolver.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13)
ld : error : object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(fxr_resolver.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13) [/Users/runner/work/1/s/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj]
##[error]ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(fxr_resolver.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13)
ld : error : object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(trace.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13) [/Users/runner/work/1/s/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj]
##[error]ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(trace.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13)
ld : error : object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(trace.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13) [/Users/runner/work/1/s/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj]
##[error]ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(trace.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13)
ld : error : object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(pal.unix.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13) [/Users/runner/work/1/s/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj]
##[error]ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(pal.unix.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13)
ld : error : object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(pal.unix.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13) [/Users/runner/work/1/s/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj]

@jkoritzinsky as you added that path to the test project, would you know what needs to be updated to link against >= 10.14? Presumably this path

runtime/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj

Lines 75 to 76 in 7e408a0

 <TargetTripleCondition="'$(TargetArchitecture)' == 'arm64'">arm64-apple-macos11</TargetTriple> 
 <TargetTripleCondition="'$(TargetArchitecture)' == 'x64'">x86_64-apple-macos10.13</TargetTriple> 

?

jkoritzinsky · 2022-03-16T16:07:21Z

@ViktorHofer I believe you're correct. We should update line 76 to be x86_64-apple-macos10.14

* Remove dotnet6 feeds dotnet7 feeds are currently the target feeds for the main branch. The dotnet6 feeds shouldn't be used anymore. * Update targetingpacks.targets * Update prebuilt package versions * Update NativeExports.csproj

Remove dotnet6 feeds
6856a76
dotnet7 feeds are currently the target feeds for the main branch. The dotnet6 feeds shouldn't be used anymore.

ViktorHofer added the area-Infrastructure label Mar 10, 2022

ViktorHofer self-assigned this Mar 10, 2022

This was referenced Mar 10, 2022
Remove VersionPrefix so that it is inferred dotnet/msquic#71
Merged
dotnet/optimization builds are broken #66646
Closed

ViktorHofer added 2 commits March 15, 2022 11:14

Update targetingpacks.targets
38e2e21

Update prebuilt package versions
32e8b29

ViktorHofer marked this pull request as ready for review March 15, 2022 15:30

ViktorHofer requested a review from a teamMarch 15, 2022 15:30

agocke approved these changes Mar 15, 2022
View reviewed changes

Update NativeExports.csproj
a62d63c

ViktorHofer merged commit b5edcab into mainMar 17, 2022

ViktorHofer deleted the ViktorHofer-patch-1 branch March 17, 2022 07:42

ghost locked as resolved and limited conversation to collaborators Apr 16, 2022

Uh oh!

Conversation

ViktorHofer commented Mar 10, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Mar 10, 2022

Uh oh!

ViktorHofer commented Mar 10, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ViktorHofer commented Mar 15, 2022

Uh oh!

ViktorHofer commented Mar 15, 2022

Uh oh!

ViktorHofer commented Mar 15, 2022

Uh oh!

azure-pipelinesBot commented Mar 15, 2022

Uh oh!

ViktorHofer commented Mar 15, 2022

Uh oh!

azure-pipelinesBot commented Mar 15, 2022

Uh oh!

azure-pipelinesBot commented Mar 15, 2022

Uh oh!

ViktorHofer commented Mar 15, 2022

Uh oh!

azure-pipelinesBot commented Mar 15, 2022

Uh oh!

agocke left a comment

Choose a reason for hiding this comment

Uh oh!

ViktorHofer commented Mar 16, 2022

Uh oh!

jkoritzinsky commented Mar 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ViktorHofer commented Mar 10, 2022•
edited
Loading

ViktorHofer commented Mar 10, 2022•
edited
Loading